Skip to content

Commit

Permalink
Merge pull request #11251 from fabriziopandini/clarify-MinReadySecond…
Browse files Browse the repository at this point in the history
…s-transition

 📖 Clarify MinReadySeconds transition in the v1Beta2 API
k8s-ci-robot authored Oct 6, 2024

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
2 parents 9569cd6 + 44168ad commit b4d05d9
Showing 1 changed file with 5 additions and 2 deletions.
7 changes: 5 additions & 2 deletions docs/proposals/20240916-improve-status-in-CAPI-resources.md
Original file line number Diff line number Diff line change
@@ -420,14 +420,17 @@ type MachineReadinessGate struct {

| v1beta1 (tentative Dec 2024) | v1Beta2 (tentative Apr 2025) | v1beta2 after v1beta1 removal (tentative Apr 2026) |
|------------------------------|------------------------------|----------------------------------------------------|
| `MinReadySeconds` (new) | `MinReadySeconds` | `MinReadySeconds` |
| | `MinReadySeconds` (renamed) | `MinReadySeconds` |
| `ReadinessGates` (new) | `ReadinessGates` | `ReadinessGates` |
| other fields... | other fields... | other fields... |

Notes:
- Both `MinReadySeconds` and `ReadinessGates` should be treated as other in-place propagated fields (changing them should not trigger rollouts).
- As of today v1beta1 MachineDeployments, MachineSets, MachinePools already have a `spec.MinReadySeconds` field.
In v1beta2 those field are going to be migrated to MachineDeployments, MachineSets, MachinePools `spec.template.spec.MinReadySeconds` field, which is
the `MinReadySeconds` field added in the first line of the table above.
- Similarly to Pod's `ReadinessGates`, also Machine's `ReadinessGates` accept only conditions with positive polarity;
The Cluster API project might revisit this in the future to stay aligned with Kubernetes or if there are use cases justifying this change.
- Both `MinReadySeconds` and `ReadinessGates` should be treated as other in-place propagated fields (changing them should not trigger rollouts).

#### Machine Print columns

0 comments on commit b4d05d9

Please sign in to comment.