Skip to content

Commit

Permalink
reeable MHC unit tests
Browse files Browse the repository at this point in the history
  • Loading branch information
cahillsf committed Jul 19, 2024
1 parent 95e8d4b commit 96d1bee
Showing 1 changed file with 1 addition and 6 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -876,13 +876,10 @@ func TestMachineHealthCheck_Reconcile(t *testing.T) {
})

t.Run("when a Machine has no Node ref for longer than the NodeStartupTimeout", func(t *testing.T) {
// FIXME: Resolve flaky/failing test
t.Skip("skipping until made stable")
g := NewWithT(t)
cluster := createCluster(g, ns.Name)

mhc := newMachineHealthCheck(cluster.Namespace, cluster.Name)
mhc.Spec.NodeStartupTimeout = &metav1.Duration{Duration: time.Second}

g.Expect(env.Create(ctx, mhc)).To(Succeed())
defer func(do ...client.Object) {
Expand Down Expand Up @@ -976,8 +973,6 @@ func TestMachineHealthCheck_Reconcile(t *testing.T) {
})

t.Run("when a Machine's Node has gone away", func(t *testing.T) {
// FIXME: Resolve flaky/failing test
t.Skip("skipping until made stable")
g := NewWithT(t)
cluster := createCluster(g, ns.Name)

Expand Down Expand Up @@ -2645,7 +2640,7 @@ func newMachineHealthCheck(namespace, clusterName string) *clusterv1.MachineHeal
},
},
MaxUnhealthy: &maxUnhealthy,
NodeStartupTimeout: &metav1.Duration{Duration: 1 * time.Millisecond},
NodeStartupTimeout: &metav1.Duration{Duration: 5 * time.Second},
UnhealthyConditions: []clusterv1.UnhealthyCondition{
{
Type: corev1.NodeReady,
Expand Down

0 comments on commit 96d1bee

Please sign in to comment.