Skip to content

Commit

Permalink
Merge pull request #8630 from dalees/comment_grammar
Browse files Browse the repository at this point in the history
📖 Minor documentation grammar changes for code comments.
  • Loading branch information
k8s-ci-robot authored May 10, 2023
2 parents c36f4c0 + 3a5cbb9 commit 91277b5
Show file tree
Hide file tree
Showing 3 changed files with 3 additions and 3 deletions.
2 changes: 1 addition & 1 deletion exp/addons/api/v1beta1/clusterresourceset_webhook.go
Original file line number Diff line number Diff line change
Expand Up @@ -71,7 +71,7 @@ func (m *ClusterResourceSet) ValidateDelete() error {

func (m *ClusterResourceSet) validate(old *ClusterResourceSet) error {
// NOTE: ClusterResourceSet is behind ClusterResourceSet feature gate flag; the web hook
// must prevent creating new objects new case the feature flag is disabled.
// must prevent creating new objects when the feature flag is disabled.
if !feature.Gates.Enabled(feature.ClusterResourceSet) {
return field.Forbidden(
field.NewPath("spec"),
Expand Down
2 changes: 1 addition & 1 deletion exp/api/v1beta1/machinepool_webhook.go
Original file line number Diff line number Diff line change
Expand Up @@ -95,7 +95,7 @@ func (m *MachinePool) ValidateDelete() error {

func (m *MachinePool) validate(old *MachinePool) error {
// NOTE: MachinePool is behind MachinePool feature gate flag; the web hook
// must prevent creating new objects new case the feature flag is disabled.
// must prevent creating new objects when the feature flag is disabled.
specPath := field.NewPath("spec")
if !feature.Gates.Enabled(feature.MachinePool) {
return field.Forbidden(
Expand Down
2 changes: 1 addition & 1 deletion internal/webhooks/clusterclass.go
Original file line number Diff line number Diff line change
Expand Up @@ -129,7 +129,7 @@ func (webhook *ClusterClass) ValidateDelete(ctx context.Context, obj runtime.Obj

func (webhook *ClusterClass) validate(ctx context.Context, oldClusterClass, newClusterClass *clusterv1.ClusterClass) error {
// NOTE: ClusterClass and managed topologies are behind ClusterTopology feature gate flag; the web hook
// must prevent creating new objects new case the feature flag is disabled.
// must prevent creating new objects when the feature flag is disabled.
if !feature.Gates.Enabled(feature.ClusterTopology) {
return field.Forbidden(
field.NewPath("spec"),
Expand Down

0 comments on commit 91277b5

Please sign in to comment.