🌱 CAPD webhooks should use 9443 as port

Another change that came up during controller runtime v0.7 investigation, the port that the CAPD container was listening on was 443 instead of the widely used 9443 (all our controllers use this value). Changes the container ports and hardcodes the port in the manager. If we want to expose a flag we can do it separately. Signed-off-by: Vince Prignano <[email protected]>
kubernetes-sigs · Oct 7, 2020 · 56b5822 · 56b5822
1 parent 1e90432
commit 56b5822
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 3 deletions.
diff --git a/test/infrastructure/docker/config/webhook/manager_webhook_patch.yaml b/test/infrastructure/docker/config/webhook/manager_webhook_patch.yaml
@@ -9,7 +9,7 @@ spec:
       containers:
       - name: manager
         ports:
-        - containerPort: 443
+        - containerPort: 9443
           name: webhook-server
           protocol: TCP
         volumeMounts:

diff --git a/test/infrastructure/docker/config/webhook/service.yaml b/test/infrastructure/docker/config/webhook/service.yaml
@@ -7,6 +7,6 @@ metadata:
 spec:
   ports:
     - port: 443
-      targetPort: 443
+      targetPort: 9443
   selector:
     control-plane: controller-manager
diff --git a/test/infrastructure/docker/main.go b/test/infrastructure/docker/main.go
@@ -18,11 +18,12 @@ package main
 
 import (
 	"flag"
-	"github.com/spf13/pflag"
 	"math/rand"
 	"os"
 	"time"
 
+	"github.com/spf13/pflag"
+
 	"k8s.io/apimachinery/pkg/runtime"
 	"k8s.io/client-go/kubernetes/scheme"
 	_ "k8s.io/client-go/plugin/pkg/client/auth/gcp"
@@ -80,6 +81,7 @@ func main() {
 		LeaderElectionID:       "controller-leader-election-capd",
 		SyncPeriod:             &syncPeriod,
 		HealthProbeBindAddress: healthAddr,
+		Port:                   9443,
 	})
 	if err != nil {
 		setupLog.Error(err, "unable to start manager")