Skip to content

Commit

Permalink
Not klog v2 change in v1alpha4 provider docs
Browse files Browse the repository at this point in the history
This updates the v1alpha3-to-v1alpha4 docs to call out the move to
klogv2 and recommending that all cluster providers do the same.

Signed-off-by: Sean McGinnis <[email protected]>
  • Loading branch information
stmcginnis committed Mar 12, 2021
1 parent b69d0db commit 4a2a287
Showing 1 changed file with 10 additions and 0 deletions.
10 changes: 10 additions & 0 deletions docs/book/src/developer/providers/v1alpha3-to-v1alpha4.md
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,16 @@

- Find and replace the `kube-rbac-proxy` version (usually the image is `gcr.io/kubebuilder/kube-rbac-proxy`) and update it to `v0.8.0`.

## Klog version

- The klog package used has been upgraded to v2.5.x. It is recommended that
all providers also switch to using v2.

- Change `import k8s.io/klog` to `import k8s.io/klog/v2`
- Change `import k8s.io/klog/klogr` to `import k8s.io/klog/v2/klogr`
- Update `go.mod` to `k8s.io/klog/v2 v2.5.0`
- Run `go mod tidy` to ensure all dependencies are updated.

## The controllers.DeleteNodeAnnotation constant has been removed

- This annotation `cluster.k8s.io/delete-machine` was originally deprecated a while ago when we moved our types under the `x-k8s.io` domain.
Expand Down

0 comments on commit 4a2a287

Please sign in to comment.