Merge pull request #4505 from enxebre/rename-unit-calculatestatus

🌱 Rename unit test to TestCalculateStatus
kubernetes-sigs · Apr 21, 2021 · 46dc43a · 46dc43a
2 parents 102c753 + dcfd306
commit 46dc43a
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 4 deletions.
diff --git a/controllers/machinedeployment_sync.go b/controllers/machinedeployment_sync.go
@@ -356,7 +356,7 @@ func (r *MachineDeploymentReconciler) syncDeploymentStatus(allMSs []*clusterv1.M
 	return nil
 }
 
-// calculateStatus calculates the latest status for the provided deployment by looking into the provided machine sets.
+// calculateStatus calculates the latest status for the provided deployment by looking into the provided MachineSets.
 func calculateStatus(allMSs []*clusterv1.MachineSet, newMS *clusterv1.MachineSet, deployment *clusterv1.MachineDeployment) clusterv1.MachineDeploymentStatus {
 	availableReplicas := mdutil.GetAvailableReplicaCountForMachineSets(allMSs)
 	totalReplicas := mdutil.GetReplicaCountForMachineSets(allMSs)

diff --git a/controllers/machinedeployment_sync_test.go b/controllers/machinedeployment_sync_test.go
@@ -20,14 +20,13 @@ import (
 	"testing"
 
 	. "github.com/onsi/gomega"
-
 	metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"
 	"k8s.io/utils/pointer"
 	clusterv1 "sigs.k8s.io/cluster-api/api/v1alpha4"
 	capierrors "sigs.k8s.io/cluster-api/errors"
 )
 
-func TestMachineDeploymentSyncStatus(t *testing.T) {
+func TestCalculateStatus(t *testing.T) {
 	msStatusError := capierrors.MachineSetStatusError("some failure")
 
 	var tests = map[string]struct {
@@ -165,7 +164,7 @@ func TestMachineDeploymentSyncStatus(t *testing.T) {
 				Phase:               "ScalingDown",
 			},
 		},
-		"machine set failed": {
+		"MachineSet failed": {
 			machineSets: []*clusterv1.MachineSet{{
 				Spec: clusterv1.MachineSetSpec{
 					Replicas: pointer.Int32Ptr(2),