CAPD: delete container after failed start to work around port allocat…

…ion issues
kubernetes-sigs · Aug 7, 2023 · 3b240eb · 3b240eb
1 parent ea27b14
commit 3b240eb
Showing 1 changed file with 7 additions and 1 deletion.
diff --git a/test/infrastructure/container/docker.go b/test/infrastructure/container/docker.go
@@ -505,7 +505,13 @@ func (d *dockerRuntime) RunContainer(ctx context.Context, runConfig *RunContaine
 
 	// Actually start the container
 	if err := d.dockerClient.ContainerStart(ctx, resp.ID, types.ContainerStartOptions{}); err != nil {
-		return errors.Wrapf(err, "error starting container %q", runConfig.Name)
+		err := errors.Wrapf(err, "error starting container %q", runConfig.Name)
+		// Delete the container and retry later on. This helps getting around the race
+		// condition where of hitting "port is already allocated" issues.
+		if innerErr := d.dockerClient.ContainerRemove(ctx, resp.ID, types.ContainerRemoveOptions{Force: true, RemoveVolumes: true}); innerErr != nil {
+			return errors.Wrapf(innerErr, "error removing container after failed start: %s", err)
+		}
+		return err
 	}
 
 	if output != nil {