Skip to content

Commit

Permalink
Merge pull request #7779 from sbueringer/pr-fix-md-replicas-comment
Browse files Browse the repository at this point in the history
🌱 Cluster topology: fix comment about MD replicas defaulting
  • Loading branch information
k8s-ci-robot authored Dec 22, 2022
2 parents 6095481 + 0c80b9d commit 1eedede
Show file tree
Hide file tree
Showing 5 changed files with 6 additions and 6 deletions.
2 changes: 1 addition & 1 deletion api/v1beta1/cluster_types.go
Original file line number Diff line number Diff line change
Expand Up @@ -171,7 +171,7 @@ type MachineDeploymentTopology struct {
FailureDomain *string `json:"failureDomain,omitempty"`

// Replicas is the number of worker nodes belonging to this set.
// If the value is nil, the MachineDeployment is created without the number of Replicas (defaulting to zero)
// If the value is nil, the MachineDeployment is created without the number of Replicas (defaulting to 1)
// and it's assumed that an external entity (like cluster autoscaler) is responsible for the management
// of this value.
// +optional
Expand Down
2 changes: 1 addition & 1 deletion api/v1beta1/zz_generated.openapi.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 2 additions & 2 deletions config/crd/bases/cluster.x-k8s.io_clusters.yaml

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Original file line number Diff line number Diff line change
Expand Up @@ -607,7 +607,7 @@ Note: Builtin variables are defined in [Builtin variables](#builtin-variables) b
Name string `json:"name"`
// The number of worker nodes belonging to this set.
// If the value is nil, the MachineDeployment is created without the number of Replicas (defaulting to zero)
// If the value is nil, the MachineDeployment is created without the number of Replicas (defaulting to 1)
// and it's assumed that an external entity (like cluster autoscaler) is responsible for the management
// of this value.
// +optional
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -525,7 +525,7 @@ components:
replicas:
description: Replicas is the number of worker nodes belonging to this set.
If the value is nil, the MachineDeployment is created without the number
of Replicas (defaulting to zero) and it's assumed that an external entity
of Replicas (defaulting to 1) and it's assumed that an external entity
(like cluster autoscaler) is responsible for the management of this value.
format: int32
type: integer
Expand Down

0 comments on commit 1eedede

Please sign in to comment.