Merge pull request #6127 from k8s-infra-cherrypick-robot/cherry-pick-…

…5868-to-release-0.4 🐛 Fix control plane upgrade test etcd and dns image upgrade
kubernetes-sigs · Feb 15, 2022 · 0234afe · 0234afe
2 parents ea09dc1 + 49f6dab
commit 0234afe
Showing 1 changed file with 5 additions and 11 deletions.
diff --git a/test/framework/controlplane_helpers.go b/test/framework/controlplane_helpers.go
@@ -309,19 +309,13 @@ func UpgradeControlPlaneAndWaitForUpgrade(ctx context.Context, input UpgradeCont
 		input.ControlPlane.Spec.KubeadmConfigSpec.ClusterConfiguration = new(bootstrapv1.ClusterConfiguration)
 	}
 
-	input.ControlPlane.Spec.KubeadmConfigSpec.ClusterConfiguration.Etcd = bootstrapv1.Etcd{
-		Local: &bootstrapv1.LocalEtcd{
-			ImageMeta: bootstrapv1.ImageMeta{
-				ImageTag: input.EtcdImageTag,
-			},
-		},
-	}
-	input.ControlPlane.Spec.KubeadmConfigSpec.ClusterConfiguration.DNS = bootstrapv1.DNS{
-		ImageMeta: bootstrapv1.ImageMeta{
-			ImageTag: input.DNSImageTag,
-		},
+	if input.ControlPlane.Spec.KubeadmConfigSpec.ClusterConfiguration.Etcd.Local == nil {
+		input.ControlPlane.Spec.KubeadmConfigSpec.ClusterConfiguration.Etcd.Local = new(bootstrapv1.LocalEtcd)
 	}
 
+	input.ControlPlane.Spec.KubeadmConfigSpec.ClusterConfiguration.Etcd.Local.ImageMeta.ImageTag = input.EtcdImageTag
+	input.ControlPlane.Spec.KubeadmConfigSpec.ClusterConfiguration.DNS.ImageMeta.ImageTag = input.DNSImageTag
+
 	Expect(patchHelper.Patch(ctx, input.ControlPlane)).To(Succeed())
 
 	log.Logf("Waiting for control-plane machines to have the upgraded kubernetes version")