allow kcp spec version changes

kubernetes-sigs · Mar 9, 2020 · 004ecfa · 004ecfa
1 parent 5f5e57f
commit 004ecfa
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 0 deletions.
diff --git a/controlplane/kubeadm/api/v1alpha3/kubeadm_control_plane_webhook.go b/controlplane/kubeadm/api/v1alpha3/kubeadm_control_plane_webhook.go
@@ -77,6 +77,7 @@ func (in *KubeadmControlPlane) ValidateUpdate(old runtime.Object) error {
 		{spec, kubeadmConfigSpec, clusterConfiguration, "etcd", "local", "imageTag"},
 		{spec, "infrastructureTemplate", "name"},
 		{spec, "replicas"},
+		{spec, "version"},
 	}
 
 	allErrs := in.validateCommon()

diff --git a/controlplane/kubeadm/api/v1alpha3/kubeadm_control_plane_webhook_test.go b/controlplane/kubeadm/api/v1alpha3/kubeadm_control_plane_webhook_test.go
@@ -612,6 +612,7 @@ func TestPaths(t *testing.T) {
 			diff: map[string]interface{}{
 				"spec": map[string]interface{}{
 					"replicas": 4,
+					"version":  "1.17.3",
 					"kubeadmConfigSpec": map[string]interface{}{
 						"clusterConfiguration": map[string]interface{}{
 							"version": "v2.0.1",
@@ -625,6 +626,7 @@ func TestPaths(t *testing.T) {
 			},
 			expected: [][]string{
 				{"spec", "replicas"},
+				{"spec", "version"},
 				{"spec", "kubeadmConfigSpec", "joinConfiguration"},
 				{"spec", "kubeadmConfigSpec", "clusterConfiguration", "version"},
 				{"spec", "kubeadmConfigSpec", "initConfiguration", "bootstrapToken"},