-
Notifications
You must be signed in to change notification settings - Fork 296
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Set network interface name with cloud-init set-name #838
Merged
k8s-ci-robot
merged 3 commits into
kubernetes-sigs:master
from
yastij:cherry-pick-deviceName
Mar 19, 2020
Merged
Set network interface name with cloud-init set-name #838
k8s-ci-robot
merged 3 commits into
kubernetes-sigs:master
from
yastij:cherry-pick-deviceName
Mar 19, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Yassine TIJANI <[email protected]> Co-authored-by: Greg May <[email protected]>
k8s-ci-robot
added
cncf-cla: yes
Indicates the PR's author has signed the CNCF CLA.
size/L
Denotes a PR that changes 100-499 lines, ignoring generated files.
labels
Mar 18, 2020
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: yastij The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
Indicates a PR has been approved by an approver from all required OWNERS files.
label
Mar 18, 2020
/hold awaiting change to v1alpha2 types |
k8s-ci-robot
added
the
do-not-merge/hold
Indicates that a PR should not merge because someone has issued a /hold command.
label
Mar 18, 2020
Signed-off-by: Yassine TIJANI <[email protected]>
randomvariable
requested changes
Mar 18, 2020
/unhold |
k8s-ci-robot
removed
the
do-not-merge/hold
Indicates that a PR should not merge because someone has issued a /hold command.
label
Mar 18, 2020
Co-Authored-By: Naadir Jeewa <[email protected]>
yastij
force-pushed
the
cherry-pick-deviceName
branch
from
March 19, 2020 12:01
1b18f8d
to
3d5ccf6
Compare
/lgtm |
k8s-ci-robot
added
the
lgtm
"Looks good to me", indicates that a PR is ready to be merged.
label
Mar 19, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
approved
Indicates a PR has been approved by an approver from all required OWNERS files.
cncf-cla: yes
Indicates the PR's author has signed the CNCF CLA.
lgtm
"Looks good to me", indicates that a PR is ready to be merged.
size/L
Denotes a PR that changes 100-499 lines, ignoring generated files.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Yassine TIJANI [email protected]
Co-authored-by: Greg May [email protected]
What this PR does / why we need it: This PR moves bits of #707 to v1alpha3
Which issue(s) this PR fixes : Fixes #834
Special notes for your reviewer:
/cc @akutz @randomvariable
Please confirm that if this PR changes any image versions, then that's the sole change this PR makes.
Release note: