Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set network interface name with cloud-init set-name #838

Merged
merged 3 commits into from
Mar 19, 2020

Conversation

yastij
Copy link
Member

@yastij yastij commented Mar 18, 2020

Signed-off-by: Yassine TIJANI [email protected]

Co-authored-by: Greg May [email protected]

What this PR does / why we need it: This PR moves bits of #707 to v1alpha3

Which issue(s) this PR fixes : Fixes #834

Special notes for your reviewer:

/cc @akutz @randomvariable

Please confirm that if this PR changes any image versions, then that's the sole change this PR makes.

Release note:

re-introduce support for static ip assignment that existed previously in v1alpha2 to avoid regression

Signed-off-by: Yassine TIJANI <[email protected]>

Co-authored-by: Greg May <[email protected]>
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Mar 18, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: yastij

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 18, 2020
@randomvariable
Copy link
Member

/hold

awaiting change to v1alpha2 types

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 18, 2020
pkg/util/machines_test.go Outdated Show resolved Hide resolved
@randomvariable
Copy link
Member

/unhold

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 18, 2020
Co-Authored-By: Naadir Jeewa <[email protected]>
@yastij yastij force-pushed the cherry-pick-deviceName branch from 1b18f8d to 3d5ccf6 Compare March 19, 2020 12:01
@randomvariable
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 19, 2020
@k8s-ci-robot k8s-ci-robot merged commit 0e0f952 into kubernetes-sigs:master Mar 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fail to assign static ipv4 addresses to machines
3 participants