Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cater for cloud provider region & zone vsphere tags during manifest generation #699

Closed
wants to merge 2 commits into from
Closed

cater for cloud provider region & zone vsphere tags during manifest generation #699

wants to merge 2 commits into from

Conversation

MnrGreg
Copy link
Contributor

@MnrGreg MnrGreg commented Dec 19, 2019 •
edited
Loading

/kind feature
/hold
/assign @akutz

What this PR does / why we need it:
Takes vSphere Cloud Provider Region & Zone Labels as input into generate.sh manifest generator.

  • Updates kind:VSphereCluster spec:cloudProviderConfiguration for post-67u3 vsphere
  • Updates vsphere.conf and kubeletExtraArgs for pre-67u3 vsphere
  • Updates getting_started.md with enabling environment variables:
cat <<EOF >envvars.txt
export VSPHERE_REGION_TAG="k8s-region" 
export VSPHERE_ZONE_TAG="k8s-zone"    
...
EOF

Which issue(s) this PR fixes
Fixes #674

Special notes for your reviewer:

PR does not change any e2e tests.

Please confirm that if this PR changes any image versions, then that's the sole change this PR makes.

NONE

Signed-off-by: Greg May [email protected]

@k8s-ci-robot k8s-ci-robot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. kind/feature Categorizes issue or PR as related to a new feature. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Dec 19, 2019
@k8s-ci-robot
Copy link
Contributor

Welcome @MnrGreg!

It looks like this is your first PR to kubernetes-sigs/cluster-api-provider-vsphere 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/cluster-api-provider-vsphere has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Dec 19, 2019
@k8s-ci-robot
Copy link
Contributor

Hi @MnrGreg. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Dec 19, 2019
@MnrGreg
Copy link
Contributor Author

MnrGreg commented Dec 30, 2019

/unhold

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 30, 2019
@MnrGreg MnrGreg force-pushed the enable-vcp-regions-and-labels branch from 6b79df1 to 80a678f Compare January 4, 2020 00:19
@k8s-ci-robot k8s-ci-robot added needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jan 4, 2020
@MnrGreg MnrGreg changed the base branch from master to release-0.5 January 4, 2020 00:19
@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jan 4, 2020
@MnrGreg
Copy link
Contributor Author

MnrGreg commented Jan 5, 2020

/hold

@k8s-ci-robot k8s-ci-robot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. and removed needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Jan 5, 2020
@MnrGreg MnrGreg mentioned this pull request Jan 6, 2020
Closed
@frapposelli
Copy link
Member

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jan 7, 2020
@akutz
Copy link
Contributor

akutz commented Jan 7, 2020

Hi @MnrGreg,

With working e2e on master again, do you want to re-target this PR?

@MnrGreg
Copy link
Contributor Author

MnrGreg commented Jan 8, 2020

@akutz I will do. There seems to be a bug with the in-tree VCP and k8s secrets 75175

Might need to split this into an in-tree VCP PR and external CSI PR.

@akutz
Copy link
Contributor

akutz commented Jan 10, 2020

Did you ever see #505? Does that affect this at all?

@akutz
Copy link
Contributor

akutz commented Jan 10, 2020

Nevermind, I see the distinction.

/hold
/test pull-cluster-api-provider-vsphere-e2e

@k8s-ci-robot
Copy link
Contributor

@MnrGreg: The following test failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
pull-cluster-api-provider-vsphere-e2e 80a678f link /test pull-cluster-api-provider-vsphere-e2e

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@akutz
Copy link
Contributor

akutz commented Jan 10, 2020

Blocked by #717
Blocked by #505 - We need to implement #505 to apply zone/region to machine VMs in order to be able to test this PR.

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: MnrGreg
To complete the pull request process, please assign akutz
You can assign the PR to them by writing /assign @akutz in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@yastij
Copy link
Member

yastij commented Jan 13, 2020

@akutz - can you check the tagging logic we could use for our test infrastructure ? Thanks !

@MnrGreg MnrGreg mentioned this pull request Feb 2, 2020
Closed
jayunit100 pushed a commit to jayunit100/cluster-api-provider-vsphere that referenced this pull request Feb 26, 2020
@harishspqr @k8s-ci-robot
Temporary workaround a data issue in boskos service (kubernetes-sigs#699
7759225 
)
@MnrGreg
Copy link
Contributor Author

MnrGreg commented Mar 31, 2020

Closing as per #674

Simple enough to achieve with clusterctl cluster-template.yaml overrides.

@MnrGreg MnrGreg closed this Mar 31, 2020
@MnrGreg MnrGreg deleted the enable-vcp-regions-and-labels branch March 31, 2020 04:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sflxn sflxn Awaiting requested review from sflxn

@sidharthsurana sidharthsurana Awaiting requested review from sidharthsurana

Assignees

@akutz akutz

Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. kind/feature Categorizes issue or PR as related to a new feature. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@MnrGreg @k8s-ci-robot @frapposelli @akutz @yastij