Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🌱 hack: add script for creating mirror repo PRs #3234

Merged

Conversation

neolit123
Copy link
Member

What this PR does / why we need it:

Until the e2e CI is migrated to community infra, this script will be useful for all PR authors to create a PR in the mirror repo and run the CI there.

please suggest a better script name if needed.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):

NONE

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Oct 24, 2024
@k8s-ci-robot k8s-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Oct 24, 2024
@neolit123
Copy link
Member Author

/cc @chrischdi

@neolit123 neolit123 changed the title hack: add script for creating mirror repo PRs 🌱 hack: add script for creating mirror repo PRs Oct 24, 2024
@neolit123
Copy link
Member Author

/kind feature
/area test

@k8s-ci-robot k8s-ci-robot added the kind/feature Categorizes issue or PR as related to a new feature. label Oct 24, 2024
@k8s-ci-robot
Copy link
Contributor

@neolit123: The label(s) area/test cannot be applied, because the repository doesn't have them.

In response to this:

/kind feature
/area test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Copy link
Member

@chrischdi chrischdi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one nit as of that lgtm

Comment on lines +23 to +26
--json headRepository,headRepositoryOwner,headRefName,baseRefName \
-q '"https://github.com/team-cluster-api/cluster-api-provider-vsphere/compare/" \
+ .baseRefName + "..." + .headRepositoryOwner.login + ":" + .headRepository.name + ":" + .headRefName'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So it can be run when not inside the CAPV git directory

Suggested change
--json headRepository,headRepositoryOwner,headRefName,baseRefName \
-q '"https://github.com/team-cluster-api/cluster-api-provider-vsphere/compare/" \
+ .baseRefName + "..." + .headRepositoryOwner.login + ":" + .headRepository.name + ":" + .headRefName'
-R kubernetes-sigs/cluster-api-provider-vsphere \
--json headRepository,headRepositoryOwner,headRefName,baseRefName \
-q '"https://github.com/team-cluster-api/cluster-api-provider-vsphere/compare/" \
+ .baseRefName + "..." + .headRepositoryOwner.login + ":" + .headRepository.name + ":" + .headRefName'

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

updated.

Until the e2e CI is migrated to community infra, this script
will be useful for all PR authors to create a PR in the mirror
repo and run the CI there.
@neolit123 neolit123 force-pushed the 1.32-add-script-for-mirror-prs branch from 4f0f66d to 6f9a7cf Compare October 25, 2024 14:16
Copy link
Member

@chrischdi chrischdi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 25, 2024
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 1f3bdd95acba17e77de41b02944a79b862572767

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: chrischdi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 25, 2024
@k8s-ci-robot k8s-ci-robot merged commit 1c40cf8 into kubernetes-sigs:main Oct 25, 2024
11 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v1.12 milestone Oct 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants