🐛 Small test fix. Remove OwnerReference & Check for Finalizers being empty

[erwin-kok]

Two small fixes:

• The secret was created with an OwnerReference. Later on (line ~141) it is checked if the controller sets the OwnerReference by counting the number of OwnerReferences. However, this is always > 0 since the OwnerReference was explicitly set before, so this check always passes. Removed the initial OwnerReference and counting the ones set by the controller.

• Line ~237 it is stated: "should remove vspherecluster finalizer if the secret does not exist". However, it was not checked whether the Finalizers are actually empty. Added this check.

[k8s-ci-robot]

Welcome @erwin-kok!

It looks like this is your first PR to kubernetes-sigs/cluster-api-provider-vsphere 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/cluster-api-provider-vsphere has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

[k8s-ci-robot]

Hi @erwin-kok. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[neolit123]

/approve

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: neolit123

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [neolit123]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[neolit123]

/ok-to-test
/kind cleanup

thanks

[erwin-kok]

Thanks @neolit123 !
This PR still needs a lgtm, who can have a look and provide one? @chrischdi perhaps? Thanks!

[chrischdi]

Isn't the proper fix to check in line 141 that the expected ownerreference is there instead of relying on a >0 check?

[erwin-kok]

You are right, better to check the expected OwnerReference. I changed the code accordingly, and also for the Finalizer (check the expected Finalizer i.s.o. relying on >0). Can you have another look @chrischdi ? Thanks!

[chrischdi]

/lgtm

[k8s-ci-robot]

LGTM label has been added.

Git tree hash: a2828baec99eebadaec702d6f34187badfacde1d

[chrischdi]

Thanks @erwin-kok for contributing this improvement! 🎉

[chrischdi]

/hold

[chrischdi]

/hold cancel