-
Notifications
You must be signed in to change notification settings - Fork 295
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🌱 Generate vm-operator YAML instead of downloading it from GCS #2931
Conversation
/hold let's see if this actually works |
Signed-off-by: Stefan Büringer [email protected]
@@ -217,7 +217,7 @@ providers: | |||
versions: | |||
- name: v1.8.6-0-gde75746a | |||
# Use manifest from source files | |||
value: "https://storage.googleapis.com/artifacts.k8s-staging-capi-vsphere.appspot.com/vm-operator/v1.8.6-0-gde75746a.yaml" | |||
value: "file://../../../../cluster-api-provider-vsphere/test/infrastructure/vm-operator/vm-operator-v1.8.6-0-gde75746a.yaml" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure why we are going so far up that we have to go back into the CAPV repo dir, but I copied this from vc-sim.
One reason could be that this config file can even be used from 4 levels deep in another repo (?)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this is because paths are relative to the test file.
if this is true, probably we are going up too much, but this seems a generalized smell all around this file
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yup, agree :)
/hold cancel |
/assign @fabriziopandini @chrischdi I would cherry-pick this after this PR merges to all relevant branches and then cleanup the files in the bucket. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
LGTM label has been added. Git tree hash: f837229db6c88ac8bd1102fe60bb9bc45677a4e6
|
/ok-to-test |
/hold so Fabrizio can take a look if he wants |
/lgtm I would suggest to unhold only after the release |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: chrischdi, fabriziopandini The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sounds good
Yup :) #2931 (comment) |
/hold cancel |
Looks like we only need it in release-1.10. release-1.9 doesn't seem to have the vm-operator yet Will wait with merging the cherry-pick until after the release tomorrow |
/cherry-pick release-1.10 |
@sbueringer: new pull request created: #2943 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Signed-off-by: Stefan Büringer [email protected]
What this PR does / why we need it:
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):Fixes #