Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🌱 Generate vm-operator YAML instead of downloading it from GCS #2931

Merged
merged 1 commit into from
Apr 23, 2024

Conversation

sbueringer
Copy link
Member

Signed-off-by: Stefan Büringer [email protected]

What this PR does / why we need it:

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Apr 22, 2024
@sbueringer
Copy link
Member Author

/hold

let's see if this actually works

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 22, 2024
Makefile Outdated Show resolved Hide resolved
@@ -217,7 +217,7 @@ providers:
versions:
- name: v1.8.6-0-gde75746a
# Use manifest from source files
value: "https://storage.googleapis.com/artifacts.k8s-staging-capi-vsphere.appspot.com/vm-operator/v1.8.6-0-gde75746a.yaml"
value: "file://../../../../cluster-api-provider-vsphere/test/infrastructure/vm-operator/vm-operator-v1.8.6-0-gde75746a.yaml"
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure why we are going so far up that we have to go back into the CAPV repo dir, but I copied this from vc-sim.

One reason could be that this config file can even be used from 4 levels deep in another repo (?)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is because paths are relative to the test file.
if this is true, probably we are going up too much, but this seems a generalized smell all around this file

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yup, agree :)

@sbueringer
Copy link
Member Author

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 23, 2024
@sbueringer
Copy link
Member Author

/assign @fabriziopandini @chrischdi

I would cherry-pick this after this PR merges to all relevant branches and then cleanup the files in the bucket.

Copy link
Member

@chrischdi chrischdi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 23, 2024
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: f837229db6c88ac8bd1102fe60bb9bc45677a4e6

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 23, 2024
@sbueringer
Copy link
Member Author

/ok-to-test

@k8s-ci-robot k8s-ci-robot added the ok-to-test Indicates a non-member PR verified by an org member that is safe to test. label Apr 23, 2024
@sbueringer
Copy link
Member Author

/hold

so Fabrizio can take a look if he wants

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 23, 2024
@fabriziopandini
Copy link
Member

/lgtm
/approve

I would suggest to unhold only after the release
Also, are you planning to cleanup the published manifests as soon as they are not necessary anymore?

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: chrischdi, fabriziopandini

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [chrischdi,fabriziopandini]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sbueringer
Copy link
Member Author

/lgtm /approve

I would suggest to unhold only after the release

Sounds good

Also, are you planning to cleanup the published manifests as soon as they are not necessary anymore?

Yup :) #2931 (comment)

@sbueringer
Copy link
Member Author

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 23, 2024
@sbueringer
Copy link
Member Author

Looks like we only need it in release-1.10. release-1.9 doesn't seem to have the vm-operator yet

Will wait with merging the cherry-pick until after the release tomorrow

@k8s-ci-robot k8s-ci-robot merged commit 0097fdb into kubernetes-sigs:main Apr 23, 2024
17 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v1.11 milestone Apr 23, 2024
@sbueringer
Copy link
Member Author

/cherry-pick release-1.10

@k8s-infra-cherrypick-robot

@sbueringer: new pull request created: #2943

In response to this:

/cherry-pick release-1.10

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants