Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🌱 Promote rvanderp3 to reviewer #2483

Merged
merged 1 commit into from
Jan 2, 2024
Merged

🌱 Promote rvanderp3 to reviewer #2483

merged 1 commit into from
Jan 2, 2024

Conversation

vincepri
Copy link
Member

@vincepri vincepri commented Nov 2, 2023

What this PR does / why we need it:

Adding @rvanderp3 as a reviewer.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Nov 2, 2023
@k8s-ci-robot k8s-ci-robot added the do-not-merge/invalid-owners-file Indicates that a PR should not merge because it has an invalid OWNERS file in it. label Nov 2, 2023
chrischdi
chrischdi reviewed Nov 2, 2023
View reviewed changes
Copy link
Member

@chrischdi chrischdi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 2, 2023
@chrischdi
Copy link
Member

/approve cancel

Looks like @rvanderp3 , you need to join the kubernetes-sigs org first.

@k8s-ci-robot k8s-ci-robot removed the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 2, 2023
@sbueringer
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 2, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: b9054123b87b4cc473ff4dd412f9310a6addb740

killianmuldoon
killianmuldoon reviewed Nov 2, 2023
View reviewed changes
Copy link
Contributor

@killianmuldoon killianmuldoon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@killianmuldoon
Copy link
Contributor

/verify-owners

@killianmuldoon
Copy link
Contributor

/retest

@killianmuldoon
Copy link
Contributor

kubernetes/org#4575 needs to merge before this is unblocked.

@vincepri
Copy link
Member Author

/verify-owners

@sbueringer
Copy link
Member

sbueringer commented Nov 14, 2023 •
edited
Loading

@rvanderp3 I think now that the membership PR is merged, you only have to accept the inviation to the org and then we can merge this PR

@killianmuldoon
Copy link
Contributor

/verify-owners

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/invalid-owners-file Indicates that a PR should not merge because it has an invalid OWNERS file in it. label Jan 1, 2024
@killianmuldoon
Copy link
Contributor

/retest

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: killianmuldoon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 1, 2024
@killianmuldoon
Copy link
Contributor

/retest

@vincepri @sbueringer
Promote rvanderp3 to reviewer
5f07b1a 
Signed-off-by: Vince Prignano <[email protected]>
@sbueringer sbueringer force-pushed the promote-reviewer-vandercool branch from 3909ff0 to 5f07b1a Compare January 2, 2024 12:51
@sbueringer
Copy link
Member

Pushed the last commit again to force-restart the coverage action

@codecov Codecov
Copy link

codecov bot commented Jan 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (47e62f1) 63.60% compared to head (5f07b1a) 64.55%.
Report is 143 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #2483      +/-   ##
==========================================
+ Coverage   63.60%   64.55%   +0.95%     
==========================================
  Files         123      118       -5     
  Lines        8773     8585     -188     
==========================================
- Hits         5580     5542      -38     
+ Misses       2777     2615     -162     
- Partials      416      428      +12

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@k8s-ci-robot k8s-ci-robot merged commit 4a19fc9 into kubernetes-sigs:main Jan 2, 2024
12 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v1.9 milestone Jan 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@killianmuldoon killianmuldoon killianmuldoon left review comments

@chrischdi chrischdi chrischdi left review comments

@fabriziopandini fabriziopandini Awaiting requested review from fabriziopandini

Assignees

@sbueringer sbueringer

@killianmuldoon killianmuldoon

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
v1.9
Development

Successfully merging this pull request may close these issues.
5 participants
@vincepri @chrischdi @sbueringer @k8s-ci-robot @killianmuldoon