Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use a better shell command to grab the IP address #241

Merged
merged 1 commit into from
Mar 28, 2019
Merged

Use a better shell command to grab the IP address #241

merged 1 commit into from
Mar 28, 2019

Conversation

sidharthsurana
Copy link
Contributor

Verified the command on the following distros:
ubuntu - trusty,xenial,artful,bionic
photon - 2.0,3.0

Resolves #239

Change-Id: I99a915874a894baea067983e62950fc4745073b8

Verified the command on the following distros:
ubuntu - trusty,xenial,artful,bionic
photon - 2.0,3.0

Resolves #239

Change-Id: I99a915874a894baea067983e62950fc4745073b8
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Mar 27, 2019
@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Mar 27, 2019
Copy link

@sflxn sflxn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 27, 2019
@sflxn
Copy link

sflxn commented Mar 27, 2019

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sflxn, sidharthsurana

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 27, 2019
@sidharthsurana
Copy link
Contributor Author

/retest

@figo
Copy link
Contributor

figo commented Mar 28, 2019

/test pull-cluster-api-provider-vsphere-e2e

5 similar comments
@figo
Copy link
Contributor

figo commented Mar 28, 2019

/test pull-cluster-api-provider-vsphere-e2e

@figo
Copy link
Contributor

figo commented Mar 28, 2019

/test pull-cluster-api-provider-vsphere-e2e

@figo
Copy link
Contributor

figo commented Mar 28, 2019

/test pull-cluster-api-provider-vsphere-e2e

@figo
Copy link
Contributor

figo commented Mar 28, 2019

/test pull-cluster-api-provider-vsphere-e2e

@figo
Copy link
Contributor

figo commented Mar 28, 2019

/test pull-cluster-api-provider-vsphere-e2e

@k8s-ci-robot k8s-ci-robot merged commit 3982436 into kubernetes-sigs:master Mar 28, 2019
@sidharthsurana sidharthsurana deleted the fix-239 branch March 28, 2019 19:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants