-
Notifications
You must be signed in to change notification settings - Fork 295
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🌱 Align github actions with upstream CAPI #2167
🌱 Align github actions with upstream CAPI #2167
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I didn't include the make generate
and make modules
dependabot action in this PR as I'm not sure it's needed at all in CAPV. We can add it later if we have the same problem we saw in upstream CAPI.
56bc769
to
45e4c57
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thx!
Looks good to me +/- the rebase. As I wrote. Fine for me to take another look at the dependabot.yml in a separate PR
45e4c57
to
93c2924
Compare
93c2924
to
fbdd475
Compare
Signed-off-by: killianmuldoon <[email protected]>
fbdd475
to
b275a24
Compare
Thank you! /lgtm |
LGTM label has been added. Git tree hash: 894714730c1cda926da112d816e87905b7c748ab
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: sbueringer The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/cherry-pick release-1.8 |
/cherry-pick release-1.7 |
/cherry-pick release-1.6 |
/cherry-pick release-1.5 |
@sbueringer: #2167 failed to apply on top of branch "release-1.8":
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@sbueringer: #2167 failed to apply on top of branch "release-1.7":
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@sbueringer: #2167 failed to apply on top of branch "release-1.6":
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@sbueringer: #2167 failed to apply on top of branch "release-1.5":
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
- Add args to golangci-lint to show lines number kubernetes-sigs#2180 - Align github actions with upstream CAPI kubernetes-sigs#2167 - flavorgen generates all flavors by default kubernetes-sigs#2172 - only CI parts - Add verify-govulncheck target and integrate to scan action kubernetes-sigs#2174 - Use shellcheck binary instead of self-built docker image kubernetes-sigs#2211 - Add doctoc and generate + verify targets kubernetes-sigs#2147 - only CI parts
- Add args to golangci-lint to show lines number kubernetes-sigs#2180 - Align github actions with upstream CAPI kubernetes-sigs#2167 - flavorgen generates all flavors by default kubernetes-sigs#2172 - only CI parts - Add verify-govulncheck target and integrate to scan action kubernetes-sigs#2174 - Use shellcheck binary instead of self-built docker image kubernetes-sigs#2211 - Add doctoc and generate + verify targets kubernetes-sigs#2147 - only CI parts
- Add args to golangci-lint to show lines number kubernetes-sigs#2180 - Align github actions with upstream CAPI kubernetes-sigs#2167 - flavorgen generates all flavors by default kubernetes-sigs#2172 - only CI parts - Add verify-govulncheck target and integrate to scan action kubernetes-sigs#2174 - Use shellcheck binary instead of self-built docker image kubernetes-sigs#2211 - Add doctoc and generate + verify targets kubernetes-sigs#2147 - only CI parts
- Align github actions with upstream CAPI kubernetes-sigs#2167 - flavorgen generates all flavors by default kubernetes-sigs#2172 - Use shellcheck binary instead of self-built docker image kubernetes-sigs#2211
- Align github actions with upstream CAPI kubernetes-sigs#2167 - flavorgen generates all flavors by default kubernetes-sigs#2172 - Use shellcheck binary instead of self-built docker image kubernetes-sigs#2211
- Add args to golangci-lint to show lines number kubernetes-sigs#2180 - Align github actions with upstream CAPI kubernetes-sigs#2167 - flavorgen generates all flavors by default kubernetes-sigs#2172 - only CI parts - Add verify-govulncheck target and integrate to scan action kubernetes-sigs#2174 - Use shellcheck binary instead of self-built docker image kubernetes-sigs#2211 - Add doctoc and generate + verify targets kubernetes-sigs#2147 - only CI parts
- Add args to golangci-lint to show lines number kubernetes-sigs#2180 - Align github actions with upstream CAPI kubernetes-sigs#2167 - flavorgen generates all flavors by default kubernetes-sigs#2172 - only CI parts - Add verify-govulncheck target and integrate to scan action kubernetes-sigs#2174 - Use shellcheck binary instead of self-built docker image kubernetes-sigs#2211 - Add doctoc and generate + verify targets kubernetes-sigs#2147 - only CI parts
- Add args to golangci-lint to show lines number kubernetes-sigs#2180 - Align github actions with upstream CAPI kubernetes-sigs#2167 - flavorgen generates all flavors by default kubernetes-sigs#2172 - only CI parts - Add verify-govulncheck target and integrate to scan action kubernetes-sigs#2174 - Use shellcheck binary instead of self-built docker image kubernetes-sigs#2211 - Add doctoc and generate + verify targets kubernetes-sigs#2147 - only CI parts
- Add args to golangci-lint to show lines number kubernetes-sigs#2180 - Align github actions with upstream CAPI kubernetes-sigs#2167 - flavorgen generates all flavors by default kubernetes-sigs#2172 - only CI parts - Add verify-govulncheck target and integrate to scan action kubernetes-sigs#2174 - Use shellcheck binary instead of self-built docker image kubernetes-sigs#2211 - Add doctoc and generate + verify targets kubernetes-sigs#2147 - only CI parts
- Add args to golangci-lint to show lines number kubernetes-sigs#2180 - Align github actions with upstream CAPI kubernetes-sigs#2167 - flavorgen generates all flavors by default kubernetes-sigs#2172 - only CI parts - Add verify-govulncheck target and integrate to scan action kubernetes-sigs#2174 - Use shellcheck binary instead of self-built docker image kubernetes-sigs#2211 - Add doctoc and generate + verify targets kubernetes-sigs#2147 - only CI parts
- Add args to golangci-lint to show lines number kubernetes-sigs#2180 - Align github actions with upstream CAPI kubernetes-sigs#2167 - flavorgen generates all flavors by default kubernetes-sigs#2172 - only CI parts - Add verify-govulncheck target and integrate to scan action kubernetes-sigs#2174 - Use shellcheck binary instead of self-built docker image kubernetes-sigs#2211 - Add doctoc and generate + verify targets kubernetes-sigs#2147 - only CI parts
- Add args to golangci-lint to show lines number kubernetes-sigs#2180 - Align github actions with upstream CAPI kubernetes-sigs#2167 - flavorgen generates all flavors by default kubernetes-sigs#2172 - only CI parts - Add verify-govulncheck target and integrate to scan action kubernetes-sigs#2174 - Use shellcheck binary instead of self-built docker image kubernetes-sigs#2211 - Add doctoc and generate + verify targets kubernetes-sigs#2147 - only CI parts
- Add args to golangci-lint to show lines number kubernetes-sigs#2180 - Align github actions with upstream CAPI kubernetes-sigs#2167 - flavorgen generates all flavors by default kubernetes-sigs#2172 - only CI parts - Add verify-govulncheck target and integrate to scan action kubernetes-sigs#2174 - Use shellcheck binary instead of self-built docker image kubernetes-sigs#2211 - Add doctoc and generate + verify targets kubernetes-sigs#2147 - only CI parts
- Add args to golangci-lint to show lines number kubernetes-sigs#2180 - Align github actions with upstream CAPI kubernetes-sigs#2167 - flavorgen generates all flavors by default kubernetes-sigs#2172 - only CI parts - Add verify-govulncheck target and integrate to scan action kubernetes-sigs#2174 - Use shellcheck binary instead of self-built docker image kubernetes-sigs#2211 - Add doctoc and generate + verify targets kubernetes-sigs#2147 - only CI parts
Aligns the github actions used in this repo with those used in upstream Cluster API c/f https://github.com/kubernetes-sigs/cluster-api/tree/main/.github/workflows
Fixes #2059