Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🌱 Bump kpromo to v4.0.4 #2139

Merged
merged 1 commit into from
Aug 2, 2023

Conversation

sbueringer
Copy link
Member

What this PR does / why we need it:
Just saw that we're using an old version while debugging why kpromo failed on some k8s.io/k8s.io PR

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Aug 2, 2023
@k8s-ci-robot k8s-ci-robot requested review from srm09 and zhanggbj August 2, 2023 11:39
@sbueringer sbueringer changed the title Bump kpromo to v4.0.4 🌱 Bump kpromo to v4.0.4 Aug 2, 2023
@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Aug 2, 2023
@@ -742,10 +742,10 @@ $(SETUP_ENVTEST): # Build setup-envtest.
GOBIN=$(TOOLS_BIN_DIR) $(GO_INSTALL) $(SETUP_ENVTEST_PKG) $(SETUP_ENVTEST_BIN) $(SETUP_ENVTEST_VER)

$(KPROMO):
Copy link
Member Author

@sbueringer sbueringer Aug 2, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apparently it worked before, just changed it for consistency

@sbueringer
Copy link
Member Author

/assign @chrischdi

Copy link
Member

@chrischdi chrischdi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 2, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 6f9e31390a56f75fec28242e3c62727f36d4b190

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: chrischdi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 2, 2023
@chrischdi
Copy link
Member

@sbueringer to be cherry-picked, right?

@k8s-ci-robot k8s-ci-robot merged commit 122af25 into kubernetes-sigs:main Aug 2, 2023
@k8s-ci-robot k8s-ci-robot added this to the v1.8 milestone Aug 2, 2023
@sbueringer
Copy link
Member Author

sbueringer commented Aug 2, 2023

@sbueringer to be cherry-picked, right?

I'm not sure if we actually have to switch branches to generate the k8s.io PRs.

Independent of that. Can you maybe do a set of manual cherry-pick PRs to get this change + the changes we made today and yesterday in our Makefiles on all branches (e.g. the generate-release-notes change)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants