-
Notifications
You must be signed in to change notification settings - Fork 296
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🌱 Bump kpromo to v4.0.4 #2139
🌱 Bump kpromo to v4.0.4 #2139
Conversation
@@ -742,10 +742,10 @@ $(SETUP_ENVTEST): # Build setup-envtest. | |||
GOBIN=$(TOOLS_BIN_DIR) $(GO_INSTALL) $(SETUP_ENVTEST_PKG) $(SETUP_ENVTEST_BIN) $(SETUP_ENVTEST_VER) | |||
|
|||
$(KPROMO): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Apparently it worked before, just changed it for consistency
/assign @chrischdi |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
LGTM label has been added. Git tree hash: 6f9e31390a56f75fec28242e3c62727f36d4b190
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: chrischdi The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@sbueringer to be cherry-picked, right? |
I'm not sure if we actually have to switch branches to generate the k8s.io PRs. Independent of that. Can you maybe do a set of manual cherry-pick PRs to get this change + the changes we made today and yesterday in our Makefiles on all branches (e.g. the generate-release-notes change) |
What this PR does / why we need it:
Just saw that we're using an old version while debugging why kpromo failed on some k8s.io/k8s.io PR
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):Fixes #