Adds support for Windows worker nodes

[gab-satchi]

• Adds windows flavour to template generator
• Adds OS field to vsphere machines

What this PR does / why we need it:

Special notes for your reviewer:
Relies on an image built from this image builder PR

Release note:

Support Windows worker nodes

[k8s-ci-robot]

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To complete the pull request process, please assign frapposelli after the PR has been reviewed.
You can assign the PR to them by writing /assign @frapposelli in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[yastij]

I know it's a wip, so just high level review on the approach

[randomvariable]

@gab-satchi , if we ignore NetBIOS support, with image-builder changes, is this PR still needed?

[gab-satchi]

won't be required. The controller logic won't need changing at all but the Windows flavour template generation can still be used

[randomvariable]

@gab-satchi cool. maybe worth splitting the flavour stuff out into a separate PR, and then we can decide based on the outcome of kubernetes-sigs/cluster-api#2217

[k8s-ci-robot]

@gab-satchi: The following tests failed, say /retest to rerun all failed tests:

Test name	Commit	Details	Rerun command
pull-cluster-api-provider-vsphere-verify-crds	7957fbb	link	/test pull-cluster-api-provider-vsphere-verify-crds
pull-cluster-api-provider-vsphere-test	7957fbb	link	/test pull-cluster-api-provider-vsphere-test
pull-cluster-api-provider-vsphere-e2e	7957fbb	link	/test pull-cluster-api-provider-vsphere-e2e

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[k8s-ci-robot]

@gab-satchi: PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[rhockenbury]

If this work is still active, it might be worthwhile to solidify the naming pattern for windows machines across cluster-api providers. Perhaps consider something similiar to capz - kubernetes-sigs/cluster-api-provider-azure#1313.

[fejta-bot]

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-contributor-experience at kubernetes/community.
/lifecycle stale

[srm09]

@gab-satchi Is the PR still relevant? We could consider re-opening it at a later time.

[k8s-triage-robot]

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

• After 90d of inactivity, lifecycle/stale is applied
• After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
• After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

• Mark this issue or PR as fresh with /remove-lifecycle rotten
• Close this issue or PR with /close
• Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle rotten