Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Operating system and Container cache should live on different VMDKs #894

Open
frapposelli opened this issue Apr 9, 2020 · 10 comments
Open
Labels
help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/feature Categorizes issue or PR as related to a new feature. lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release.

Comments

@frapposelli
Copy link
Member

/kind feature

Describe the solution you'd like
I would like to see CAPV separate the operating system from the local container cache, this would be achieved by cloning the OS from a template, and then creating a new disk of the size specified with VSPHERE_DISK_GIB that would host the local image cache, enabling faster provisioning time and the ability to specify a disk size when using linked clones.

Anything else you would like to add:
This could also help during upgrade, the new node could simply mount the existing local image cache and that would speed up significantly the restart of workloads after an upgrade.

/cc @randomvariable @yastij @rosskukulinski

@k8s-ci-robot k8s-ci-robot added the kind/feature Categorizes issue or PR as related to a new feature. label Apr 9, 2020
@yastij yastij added this to the v0.7.0 milestone Apr 16, 2020
@frapposelli
Copy link
Member Author

Also I think having etcd as a separate VMDK could be a good idea, since using linked clones creates a write penalty on the disk due to copy-on-write, and etcd is very sensitive to it.

@yastij yastij added the priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. label Apr 28, 2020
@dougm
Copy link
Member

dougm commented Jul 2, 2020

The Etcd on data disk CAEP has been accepted and implementation merged.

The CAPA PR Etcd EBS Volumes is in progress based on the new CABPK disk support.

Is anyone looking at doing similar for CAPV yet?

@yastij yastij modified the milestones: v0.7.0, v0.7.x Jul 24, 2020
@fejta-bot
Copy link

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Oct 22, 2020
@yastij yastij modified the milestones: v0.7.x, v0.8.0 Nov 16, 2020
@fejta-bot
Copy link

Stale issues rot after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle rotten

@k8s-ci-robot k8s-ci-robot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Dec 16, 2020
@yastij yastij added lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. and removed lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. labels Dec 16, 2020
@rosskukulinski
Copy link

@timmycarr can you evaluate relevance now?

@omniproc
Copy link
Contributor

omniproc commented Jul 21, 2021

One downside of this approach would be that it would lower the number of PV's that can be attached since there's a hard limit of FCD's that can be added (max no. of SCSI controllers / SCSI slots)

@srm09 srm09 modified the milestones: v0.8.0, Next Jan 30, 2022
@srm09
Copy link
Contributor

srm09 commented Jan 30, 2022

/help
@timmycarr Is this something for us to tackle?

@k8s-ci-robot
Copy link
Contributor

@srm09:
This request has been marked as needing help from a contributor.

Guidelines

Please ensure that the issue body includes answers to the following questions:

  • Why are we solving this issue?
  • To address this issue, are there any code changes? If there are code changes, what needs to be done in the code and what places can the assignee treat as reference points?
  • Does this issue have zero to low barrier of entry?
  • How can the assignee reach out to you for help?

For more details on the requirements of such an issue, please see here and ensure that they are met.

If this request no longer meets these requirements, the label can be removed
by commenting with the /remove-help command.

In response to this:

/help
@timmycarr Is this something for us to tackle?

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. label Jan 30, 2022
@sbueringer sbueringer removed this from the Next milestone Aug 3, 2023
@randomvariable
Copy link
Member

This is supported in VM Operator mode. Is this needed in non-supervisor mode?

@omniproc
Copy link
Contributor

omniproc commented Aug 5, 2023

@randomvariable not sure this is ment to be related to Tanzu. This is more about additional features for vanilla CAPV, additional variables in the infrastructure provider of CAPV to be more specific.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/feature Categorizes issue or PR as related to a new feature. lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release.
Projects
None yet
Development

No branches or pull requests

10 participants