Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IPAddress Gateway should be concidered optional #2396

Closed
ekarlso opened this issue Sep 26, 2023 · 2 comments · Fixed by #2397
Closed

IPAddress Gateway should be concidered optional #2396

ekarlso opened this issue Sep 26, 2023 · 2 comments · Fixed by #2397
Labels
kind/feature Categorizes issue or PR as related to a new feature. triage/accepted Indicates an issue or PR is ready to be actively worked on.

Comments

@ekarlso
Copy link
Contributor

ekarlso commented Sep 26, 2023

/kind feature

Describe the solution you'd like
It was decided in previous discussions that Gateway should be optional so you can have interfaces without defualt gw here
kubernetes-sigs/cluster-api-ipam-provider-in-cluster#118
kubernetes-sigs/cluster-api#8536
kubernetes-sigs/cluster-api-ipam-provider-in-cluster#70

Anything else you would like to add:
[Miscellaneous information that will assist in solving the issue.]

Environment:

  • Cluster-api-provider-vsphere version:
    1.8.x
@k8s-ci-robot k8s-ci-robot added the kind/feature Categorizes issue or PR as related to a new feature. label Sep 26, 2023
ekarlso pushed a commit to ekarlso/cluster-api-provider-vsphere that referenced this issue Sep 26, 2023
@christianang
Copy link
Contributor

This is fine with me. There was a lot of back and forth on this across various repos and it seem like it was made optional everywhere, but CAPV. So this make sense to me to remove the restriction from CAPV.

cc @schrej @srm09

@chrischdi
Copy link
Member

Fore more context also see the discussion at https://kubernetes.slack.com/archives/CKFGK3SSD/p1695731228748929

As of today it is already okay for CAPV to have no gateway set for ipv6. With this use case we should do the same for ipv4 propably inside the parseGateway function:

https://github.com/kubernetes-sigs/cluster-api-provider-vsphere/blob/main/pkg/services/govmomi/ipam/parse.go#L57-L59

	if ipamAddress.Spec.Gateway == "" {
		return nil, nil
	}

/triage accepted

@k8s-ci-robot k8s-ci-robot added the triage/accepted Indicates an issue or PR is ready to be actively worked on. label Sep 27, 2023
@ekarlso ekarlso closed this as completed Oct 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature Categorizes issue or PR as related to a new feature. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants