-
Notifications
You must be signed in to change notification settings - Fork 296
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Importing API types pulls in lots of dependencies #2159
Comments
/assign |
Credit to @JoelSpeed who championed this work in the CAPI repo |
@laozc Please take a look at the linked issue for context. It should ~ come down to something like this:
We already have consensus on how to do #9045. I'll try to review #9047 soon so we have an established pattern to follow |
/assign @laozc (IIRC based on offline discussion) |
@sbueringer: GitHub didn't allow me to assign the following users: laozc. Note that only kubernetes-sigs members with read permissions, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/unassign @killianmuldoon |
@laozc |
/assign |
@laozc If you have time, the next thing we can do is the equivalent of kubernetes-sigs/cluster-api#9047 Maybe just do it for one webhook first to get a first review and then we can do the same for all |
Thx @laozc. I think the only remaining part is "Add import-boss to prevent regressions" (xref: kubernetes-sigs/cluster-api#9011 (comment)) If you have some time, I think we can already explore how to use it in CAPV without waiting for CAPI. |
Inspired by kubernetes-sigs/cluster-api#9011
We should mirror the work to reduce the number of dependencies brought in from importing API types that has been done in the core Cluster API repository at kubernetes-sigs/cluster-api#9011
This will require:
controller-runtime/pkg/scheme
in the API packagesThe text was updated successfully, but these errors were encountered: