Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Importing API types pulls in lots of dependencies #2159

Closed
killianmuldoon opened this issue Aug 3, 2023 · 10 comments · Fixed by #2338
Closed

Importing API types pulls in lots of dependencies #2159

killianmuldoon opened this issue Aug 3, 2023 · 10 comments · Fixed by #2338
Assignees

Comments

@killianmuldoon
Copy link
Contributor

Inspired by kubernetes-sigs/cluster-api#9011

We should mirror the work to reduce the number of dependencies brought in from importing API types that has been done in the core Cluster API repository at kubernetes-sigs/cluster-api#9011

This will require:

  • Moving webhooks out of the API packages
  • Dropping controller-runtime/pkg/scheme in the API packages
@killianmuldoon
Copy link
Contributor Author

/assign

@killianmuldoon
Copy link
Contributor Author

Credit to @JoelSpeed who championed this work in the CAPI repo

@sbueringer
Copy link
Member

sbueringer commented Aug 9, 2023

@laozc Please take a look at the linked issue for context. It should ~ come down to something like this:

We already have consensus on how to do #9045. I'll try to review #9047 soon so we have an established pattern to follow

@sbueringer
Copy link
Member

sbueringer commented Aug 18, 2023

/assign @laozc

(IIRC based on offline discussion)

@k8s-ci-robot
Copy link
Contributor

@sbueringer: GitHub didn't allow me to assign the following users: laozc.

Note that only kubernetes-sigs members with read permissions, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time.
For more information please see the contributor guide

In response to this:

/assign @laozc
/unassing @killianmuldoon
(IIRC based on offline discussion)

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@sbueringer
Copy link
Member

/unassign @killianmuldoon

@sbueringer
Copy link
Member

@laozc
Can you assign the issue to yourself? Unfortunately I can't do it > #2159 (comment)

@laozc
Copy link
Member

laozc commented Aug 22, 2023

/assign

@sbueringer
Copy link
Member

@laozc If you have time, the next thing we can do is the equivalent of kubernetes-sigs/cluster-api#9047

Maybe just do it for one webhook first to get a first review and then we can do the same for all

@sbueringer
Copy link
Member

Thx @laozc. I think the only remaining part is "Add import-boss to prevent regressions" (xref: kubernetes-sigs/cluster-api#9011 (comment))

If you have some time, I think we can already explore how to use it in CAPV without waiting for CAPI.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants