Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add seanschneeweiss as reviewer #874

Conversation

sbueringer
Copy link
Member

I think @seanschneeweiss would be a great addition to our team of reviewers.

This is highlighted through previous contributions and PR reviews.

Thank you for all you work until now!

I would propose a lazy consensus period until Friday 28th Mai and would merge if there are no objections until then.

/hold

@k8s-ci-robot k8s-ci-robot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels May 21, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sbueringer

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. do-not-merge/invalid-owners-file Indicates that a PR should not merge because it has an invalid OWNERS file in it. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels May 21, 2021
@jichenjc
Copy link
Contributor

not sure why it's has invalid owner file tag?

@sbueringer
Copy link
Member Author

sbueringer commented May 21, 2021

not sure why it's has invalid owner file tag?

Will be fixed, I assume today, after: kubernetes/org#2725 is resolved

@sbueringer sbueringer changed the title Add seanschneeweiss as reviewers Add seanschneeweiss as reviewer May 21, 2021
@sbueringer
Copy link
Member Author

/verify-owners

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/invalid-owners-file Indicates that a PR should not merge because it has an invalid OWNERS file in it. label May 21, 2021
@seanschneeweiss
Copy link
Contributor

Thank you very much, really appreciate being involved with this project and working together with all of you.

@jichenjc
Copy link
Contributor

/lgtm
/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 24, 2021
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 24, 2021
@k8s-ci-robot k8s-ci-robot merged commit 73f64b9 into kubernetes-sigs:master May 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants