-
Notifications
You must be signed in to change notification settings - Fork 261
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
✨ Add gophercloud request logs, fix contexts #860
✨ Add gophercloud request logs, fix contexts #860
Conversation
Hi @seanschneeweiss. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/ok-to-test |
58cc595
to
6b3c512
Compare
/test pull-cluster-api-provider-openstack-test |
@jichenjc @seanschneeweiss this needs a gofmt |
This activates the default logging for the gophercloud client, when setting the log level to 6. This adapts some contexts. Signed-off-by: Sean Schneeweiss <[email protected]>
6b3c512
to
cdb8936
Compare
/lgtm I tested in my environment. So great. |
/approve looks good |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jichenjc, sbueringer, seanschneeweiss The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/hold cancel |
What this PR does / why we need it:
This PR enables the gophercloud request logs when setting the log level to
6
with--v=6
.In addition, some contexts are fixed.
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):Fixes #854.
Special notes for your reviewer:
TODOs:
[ ] includes documentation[ ] adds unit tests/hold
Sean Schneeweiss [email protected], Daimler TSS GmbH, legal info/Impressum