Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ Add gophercloud request logs, fix contexts #860

Merged
merged 1 commit into from
May 7, 2021

Conversation

seanschneeweiss
Copy link
Contributor

What this PR does / why we need it:
This PR enables the gophercloud request logs when setting the log level to 6 with --v=6.

In addition, some contexts are fixed.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #854.

Special notes for your reviewer:

TODOs:

  • squashed commits
  • if necessary:
    • [ ] includes documentation
    • [ ] adds unit tests

/hold

Sean Schneeweiss [email protected], Daimler TSS GmbH, legal info/Impressum

@k8s-ci-robot k8s-ci-robot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels May 6, 2021
@k8s-ci-robot
Copy link
Contributor

Hi @seanschneeweiss. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label May 6, 2021
@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 6, 2021
@sbueringer
Copy link
Member

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels May 6, 2021
@seanschneeweiss seanschneeweiss force-pushed the gopher-tracelog branch 2 times, most recently from 58cc595 to 6b3c512 Compare May 6, 2021 22:24
@jichenjc
Copy link
Contributor

jichenjc commented May 7, 2021

/test pull-cluster-api-provider-openstack-test

@sbueringer
Copy link
Member

@jichenjc @seanschneeweiss this needs a gofmt

This activates the default logging for the gophercloud client,
when setting the log level to 6.
This adapts some contexts.

Signed-off-by: Sean Schneeweiss <[email protected]>
@hidekazuna
Copy link
Contributor

/lgtm

I tested in my environment. So great.

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 7, 2021
@jichenjc
Copy link
Contributor

jichenjc commented May 7, 2021

/approve

looks good

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jichenjc, sbueringer, seanschneeweiss

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [jichenjc,sbueringer]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@hidekazuna
Copy link
Contributor

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 7, 2021
@k8s-ci-robot k8s-ci-robot merged commit c3779d3 into kubernetes-sigs:master May 7, 2021
@hidekazuna hidekazuna mentioned this pull request May 12, 2021
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make it possible to enable gophercloud request logs via --v
5 participants