Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🏃 Bump zuul jobs to k8s 1.20 #780

Closed
wants to merge 2 commits into from
Closed

🏃 Bump zuul jobs to k8s 1.20 #780

wants to merge 2 commits into from

Conversation

stmcginnis
Copy link
Contributor

What this PR does / why we need it:

1.20 has been out for some time now, good to raise our tested version on
OpenLab.

Release note:

NONE

/hold

@stmcginnis
Bump zuul jobs to k8s 1.20
1232bd6 
1.20 has been out for some time now, good to raise our tested version on
OpenLab.

Signed-off-by: Sean McGinnis <[email protected]>
@k8s-ci-robot k8s-ci-robot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Mar 11, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: stmcginnis
To complete the pull request process, please assign vincepri after the PR has been reviewed.
You can assign the PR to them by writing /assign @vincepri in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot
Copy link
Contributor

Hi @stmcginnis. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Mar 11, 2021
@theopenlab-ci
Copy link

theopenlab-ci bot commented Mar 11, 2021

Build failed.

@stmcginnis
Copy link
Contributor Author

recheck

@sbueringer
Copy link
Member

sbueringer commented Mar 11, 2021 •
edited
Loading

Fine for me when tests are green. We will drop openlab and test against 1.20 through this pr #759

@sbueringer
Copy link
Member

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Mar 11, 2021
@theopenlab-ci
Copy link

theopenlab-ci bot commented Mar 11, 2021

Build failed.

@sbueringer
Copy link
Member

@stmcginnis I think you also have to change the version in the e2e-conformance.sh.

@stmcginnis
Copy link
Contributor Author

Ah, OK. I wasn't sure if we would want that updated too. Will get that updated to the latest for a default now.

@stmcginnis
Update default k8s version in e2e-conformance
88d50b5 
This raises the default kubernetes version to the current latest 1.20.4.

Signed-off-by: Sean McGinnis <[email protected]>
@theopenlab-ci
Copy link

theopenlab-ci bot commented Mar 11, 2021

Build failed.

@stmcginnis
Copy link
Contributor Author

recheck

@theopenlab-ci
Copy link

theopenlab-ci bot commented Mar 11, 2021

Build failed.

@sbueringer sbueringer mentioned this pull request Mar 12, 2021
Merged
@sbueringer
Copy link
Member

@stmcginnis I think the test failed here: https://logs.openlabtesting.org/logs/80/780/88d50b56cb14a054f8bb694b1134cc988c44ed37/check/cluster-api-provider-openstack-current-acceptance-test-v1.20-1/08b0f29/
because we're not using the right kubectl version in the tests and the 1.20 conformance test detects that. I think that's something I fixed here when migrating the tests to 1.20: https://github.com/kubernetes-sigs/cluster-api-provider-openstack/pull/759/files
I'm not entirely sure what it was but I think we're using the kubectl from ensure-kubectl and not the one we built ourselves.

But I"m hopeful we get the final reviews for PR #759 soon so we don't need #780 and can unblock your klog PR.

@k8s-ci-robot
Copy link
Contributor

@stmcginnis: PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 15, 2021
@stmcginnis
Copy link
Contributor Author

Don't think this is necessary now with the switch to prow.

@stmcginnis stmcginnis closed this Mar 15, 2021
@sbueringer
Copy link
Member

@stmcginnis I think we don't need this PR anymore as we're not using OpenLab on master anymore. I also opened an issue to drop it everywhere else: #785

EDIT: ah you were faster :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jichenjc jichenjc Awaiting requested review from jichenjc

@sbueringer sbueringer Awaiting requested review from sbueringer

Assignees
No one assigned
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@stmcginnis @k8s-ci-robot @sbueringer