🐛 Include more device_owners when looking for a port for floating ip #1996
Conversation
k8s-ci-robot
added
do-not-merge/hold
k8s-ci-robot
added
needs-ok-to-test
|
Hi @bilbobrovall. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
✅ Deploy Preview for kubernetes-sigs-cluster-api-openstack ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
/ok-to-test |
k8s-ci-robot
added
ok-to-test
| type PortListOpts struct { | ||
| DeviceOwner []string `q:"device_owner"` | ||
| NetworkID string `q:"network_id"` | ||
| } |
There was a problem hiding this comment.
@pierreprinetti: I know you've been looking at this from Gophercloud perspective. Is this the way to go here?
There was a problem hiding this comment.
Eventually hopefully not, but I think this is the only way to go currently.
|
Makes sense to me, tiny request for clarification in the comments. /lgtm |
k8s-ci-robot
added
the
lgtm
| type PortListOpts struct { | ||
| DeviceOwner []string `q:"device_owner"` | ||
| NetworkID string `q:"network_id"` | ||
| } |
There was a problem hiding this comment.
Eventually hopefully not, but I think this is the only way to go currently.
| NetworkID: instancePort.NetworkID, | ||
| DeviceOwner: "network:router_interface", | ||
| DeviceOwner: []string{"network:router_interface", "network:router_interface_distributed", "network:ha_router_replicated_interface", "network:router_ha_interface"}, |
There was a problem hiding this comment.
This is the stuff I'd really like to push into the domain of gophercloud.
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mdbooth The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
|
/hold cancel |
k8s-ci-robot
removed
the
do-not-merge/hold
What this PR does / why we need it: Adds support in
GetPortForExternalNetworkfor more distributed/ha-routersWhich issue(s) this PR fixes: Fixes #1985
I'm not 100% sure if we need all these device_owners or if we need some additional, I got them from https://github.com/openstack/neutron-lib/blob/master/neutron_lib/constants.py#L74 but didn't find any good documentation on them.
Special notes for your reviewer:
TODOs:
/hold