🐛 Fix multiple panics in restore functions #1989
Conversation
k8s-ci-robot
added
do-not-merge/hold
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mdbooth The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
approved
✅ Deploy Preview for kubernetes-sigs-cluster-api-openstack ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
/test pull-cluster-api-provider-openstack-e2e-full-test |
|
/test pull-cluster-api-provider-openstack-e2e-test |
k8s-ci-robot
added
the
needs-rebase
|
PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
mdbooth
removed
the
needs-rebase
|
/hold cancel |
k8s-ci-robot
removed
the
do-not-merge/hold
|
In case it's important later: I manually removed the |
|
/lgtm |
k8s-ci-robot
added
the
lgtm
Panics in restore functions are a particular problem because
previousis unvalidated user-provided input. It should have been generated by a previous conversion, but we have no way to enforce that. We don't need to preserve sensible behaviour given invalid input, but we should not crash.This PR implements a generic function for fuzzing restore functions, adds v1alpha6 and v1alpha7 tests which calls the fuzzer against all restore functions, and fixes all the discovered panics.
/hold