Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Revert accidental update to previous API templates #1966

Merged
merged 1 commit into from
Mar 21, 2024

Conversation

mdbooth
Copy link
Contributor

@mdbooth mdbooth commented Mar 21, 2024

#1959 accidentally updated the bastion spec for the v1alpha6 and v1alpha7 tests, which breaks the upgrade test.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Mar 21, 2024
@k8s-ci-robot k8s-ci-robot requested review from dulek and EmilienM March 21, 2024 16:34
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mdbooth

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 21, 2024
Copy link

netlify bot commented Mar 21, 2024

Deploy Preview for kubernetes-sigs-cluster-api-openstack ready!

Name Link
🔨 Latest commit 61b0560
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-sigs-cluster-api-openstack/deploys/65fc61a45b6f3100085846b5
😎 Deploy Preview https://deploy-preview-1966--kubernetes-sigs-cluster-api-openstack.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@mdbooth
Copy link
Contributor Author

mdbooth commented Mar 21, 2024

/test pull-cluster-api-provider-openstack-e2e-full-test

@dulek
Copy link
Contributor

dulek commented Mar 21, 2024

/lgtm

My bad, thank you Matt!

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 21, 2024
@mdbooth
Copy link
Contributor Author

mdbooth commented Mar 21, 2024

Until we've seen the upgrade test pass.

/hold

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 21, 2024
@mdbooth
Copy link
Contributor Author

mdbooth commented Mar 21, 2024

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 21, 2024
@k8s-ci-robot k8s-ci-robot merged commit 2b03429 into kubernetes-sigs:main Mar 21, 2024
10 checks passed
@mdbooth mdbooth deleted the upgradefix branch March 21, 2024 18:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants