-
Notifications
You must be signed in to change notification settings - Fork 261
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🌱 Add .gitattributes to identify generated files to GitHub #1963
Conversation
✅ Deploy Preview for kubernetes-sigs-cluster-api-openstack ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mdbooth The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
CAPI are using the same attribute: https://github.com/kubernetes-sigs/cluster-api/blob/main/.gitattributes |
/lgtm |
Nice! |
/hold cancel |
Example: https://docs.github.com/en/repositories/working-with-files/managing-files/customizing-how-changed-files-appear-on-github
A primary is to stop labelling relatively small commits as XXL just because they update some doctext which is referenced in several places in the CRDs.
This does what I intend in git:
However, I'm far from convinced the github integration is working. I originally included it in #1962, but it still seemed to be mislabelled.
/hold