Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

⚠️ Cleanup APILoadBalancer #1937

Merged
merged 2 commits into from
Mar 12, 2024
Merged

⚠️ Cleanup APILoadBalancer #1937

merged 2 commits into from
Mar 12, 2024

Conversation

mdbooth
Copy link
Contributor

@mdbooth mdbooth commented Mar 11, 2024

Enabled now defaults to true. Provider becomes optional.String.

/hold

mdbooth added 2 commits March 11, 2024 20:58
@mdbooth
Move misplaced sections in v1alpha7 to v1beta changes doc
44d4732
@mdbooth
Cleanup APILoadBalancer
470d30b 
Enabled now defaults to true. Provider becomes optional.String.
@k8s-ci-robot k8s-ci-robot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Mar 11, 2024
@netlify Netlify
Copy link

netlify bot commented Mar 11, 2024 •
edited
Loading

✅ Deploy Preview for kubernetes-sigs-cluster-api-openstack ready!

Name Link
🔨 Latest commit 470d30b
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-sigs-cluster-api-openstack/deploys/65ef7150d36cdf0008ae48da
😎 Deploy Preview https://deploy-preview-1937--kubernetes-sigs-cluster-api-openstack.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mdbooth

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 11, 2024
@EmilienM
Copy link
Contributor

/test pull-cluster-api-provider-openstack-e2e-full-test

@EmilienM
Copy link
Contributor

/lgtm
/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 12, 2024
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 12, 2024
@k8s-ci-robot k8s-ci-robot merged commit 2074438 into kubernetes-sigs:main Mar 12, 2024
10 checks passed
@mdbooth mdbooth deleted the openstackcluster_apicleanup branch March 12, 2024 09:46
@mdbooth mdbooth mentioned this pull request Mar 22, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jichenjc jichenjc Awaiting requested review from jichenjc

@lentzi90 lentzi90 Awaiting requested review from lentzi90

Assignees

@EmilienM EmilienM

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
CAPO Roadmap
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mdbooth @k8s-ci-robot @EmilienM