🐛 Ignore 'OS_*' environment variables #1883
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
do-not-merge/hold
k8s-ci-robot
added
the
size/XS
✅ Deploy Preview for kubernetes-sigs-cluster-api-openstack ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
stephenfin
changed the title
Users should configure things via a secret, not via environment variables. Signed-off-by: Stephen Finucane <[email protected]>
stephenfin
force-pushed
the
issues-1881
branch
from
32030fd to
23e30c7
Compare
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
/lgtm |
mandre
reviewed
Feb 16, 2024
There was a problem hiding this comment.
We had the same issue in OpenShift that we fixed in the same way.
/lgtm
mdbooth
approved these changes
Feb 16, 2024
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mdbooth, stephenfin The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
|
/hold cancel |
k8s-ci-robot
removed
the
do-not-merge/hold
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Ignore
OS_prefixed environment variables when building our clients.Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #1991
Special notes for your reviewer:
None.
TODOs:
/hold