🌱 Bump controller-tools to v0.14.0 #1825
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mdbooth The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
cncf-cla: yes
✅ Deploy Preview for kubernetes-sigs-cluster-api-openstack ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
k8s-ci-robot
added
approved
3 tasks
mdbooth
force-pushed
the
controller-tools
branch
2 times, most recently
from
a9c5eba to
b276aa8
Compare
k8s-ci-robot
added
size/XXL
Fixes a panic generating deepcopy for v1alpha1
mdbooth
force-pushed
the
controller-tools
branch
from
b276aa8 to
cbd9b44
Compare
|
/lgtm |
k8s-ci-robot
added
the
lgtm
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a panic generating deepcopy for v1alpha1.
go bump to 1.21 is because the new controller-tools pulls in a k8s 0.29 dep, which needs it. We update the top-level go to match. We also manually remove the toolchain directive which
go mod tidyadds because it breaks md-book.New version of controller-gen has different yaml output formatting, which generates a large amount of noise.