Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🌱 Migrate pkg/cloud/services/networking/network.go and router.go to structured logging #1619

Closed
wants to merge 0 commits into from

Conversation

jddaggett
Copy link
Contributor

@jddaggett jddaggett commented Jul 24, 2023

What this PR does / why we need it:

Networking logging structure changes to adhere to guidelines in Kubernetes documentation here --> https://github.com/kubernetes/community/blob/master/contributors/devel/sig-instrumentation/migration-to-structured-logging.md

/hold

TODO:

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 24, 2023
@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Jul 24, 2023

CLA Not Signed

@netlify
Copy link

netlify bot commented Jul 24, 2023

Deploy Preview for kubernetes-sigs-cluster-api-openstack ready!

Name Link
🔨 Latest commit 434cfe2
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-sigs-cluster-api-openstack/deploys/64c148b8798056000885fdaf
😎 Deploy Preview https://deploy-preview-1619--kubernetes-sigs-cluster-api-openstack.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@k8s-ci-robot k8s-ci-robot added cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jul 24, 2023
@k8s-ci-robot
Copy link
Contributor

Hi @jddaggett. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot requested review from jichenjc and mdbooth July 24, 2023 17:41
@k8s-ci-robot k8s-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Jul 24, 2023
@jichenjc
Copy link
Contributor

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jul 25, 2023
@mdbooth
Copy link
Contributor

mdbooth commented Jul 25, 2023

/lgtm

@jddaggett1 You still need to sign the CLA.

Also, you've got 3 separate commits for the 3 separate versions of this PR. This is a good way to work while iterating on a PR in GitHub, but now we've got something we want to merge we don't need or want to keep the previous ones. Please now 'squash' these commits into a single commit with a single commit message. There's likely a bunch of references around for how to do this, but ping me on slack if you have any trouble.

Lastly, please don't open a new PR for this! Just push the squashed commit to the same branch you're using for this PR.

And... lastly lastly, I just noticed that you're using the 'main' branch on your fork for this PR. This works fine, but it's going to get really confusing really quickly when you have multiple PRs. Don't change it for this PR, but for your next one I suggest you push to a branch rather than main.

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 25, 2023
@mdbooth
Copy link
Contributor

mdbooth commented Jul 25, 2023

I've added 2 TODO items to the PR before it merges. They're in the updated description.

@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 25, 2023
@k8s-ci-robot
Copy link
Contributor

New changes are detected. LGTM label has been removed.

@mdbooth
Copy link
Contributor

mdbooth commented Jul 26, 2023

Something odd has happened with the git history here! Looks like you're now trying to push 2 unrelated commits in addition to yours.

@mdbooth
Copy link
Contributor

mdbooth commented Jul 26, 2023

/check-cla

@jddaggett jddaggett closed this Jul 26, 2023
@jddaggett jddaggett force-pushed the main branch 2 times, most recently from 013bfe8 to 434cfe2 Compare July 26, 2023 16:24
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: jddaggett

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jul 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants