-
Notifications
You must be signed in to change notification settings - Fork 260
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🌱 Migrate pkg/cloud/services/networking/network.go and router.go to structured logging #1619
Conversation
|
✅ Deploy Preview for kubernetes-sigs-cluster-api-openstack ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Hi @jddaggett. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/ok-to-test |
/lgtm @jddaggett1 You still need to sign the CLA. Also, you've got 3 separate commits for the 3 separate versions of this PR. This is a good way to work while iterating on a PR in GitHub, but now we've got something we want to merge we don't need or want to keep the previous ones. Please now 'squash' these commits into a single commit with a single commit message. There's likely a bunch of references around for how to do this, but ping me on slack if you have any trouble. Lastly, please don't open a new PR for this! Just push the squashed commit to the same branch you're using for this PR. And... lastly lastly, I just noticed that you're using the 'main' branch on your fork for this PR. This works fine, but it's going to get really confusing really quickly when you have multiple PRs. Don't change it for this PR, but for your next one I suggest you push to a branch rather than main. |
I've added 2 TODO items to the PR before it merges. They're in the updated description. |
New changes are detected. LGTM label has been removed. |
Something odd has happened with the git history here! Looks like you're now trying to push 2 unrelated commits in addition to yours. |
/check-cla |
013bfe8
to
434cfe2
Compare
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: jddaggett The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What this PR does / why we need it:
Networking logging structure changes to adhere to guidelines in Kubernetes documentation here --> https://github.com/kubernetes/community/blob/master/contributors/devel/sig-instrumentation/migration-to-structured-logging.md
/hold
TODO: