-
Notifications
You must be signed in to change notification settings - Fork 260
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update cluster api #147
Update cluster api #147
Conversation
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: chaosaffe The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Update looks ok and I was able to create a cluster, but still uses gcr.io/k8s-cluster-api/cluster-api-controller:latest
.
Because we are not yet on kustomize, you also need to modify the image tag in:
/lgtm |
* format Gopkg.toml * Update cluster-api to v0.0.0-alpha.4 Resolves kubernetes-sigs#121 * Update image tag in generate-yaml.sh
What this PR does / why we need it:
Updates cluster-api dependencies to v0.0.0-alpha.4
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):Fixes #121
Special notes for your reviewer:
This PR changes us from tracking branch
master
on cluster-api to tracking tag0.0.0-alpha.4
This has the side effect of changing the image tag we use for the cluster-api controller-manager from
latest
to0.0.0-alpha.4
See kubernetes-sigs/cluster-api#635 for more information
Release note: