✨E2E error logging improvements

[mdbooth]

What this PR does / why we need it:

This makes 2 improvements to error logging in E2E tests:

• Specific improvements in gomega error reporting in the multi-network test
• Stop using --stream for ginkgo output

[netlify]

✔️ Deploy Preview for kubernetes-sigs-cluster-api-openstack ready!

🔨 Explore the source changes: c12f58b

🔍 Inspect the deploy log: https://app.netlify.com/sites/kubernetes-sigs-cluster-api-openstack/deploys/6179b2f70d7a3d0007c4d477

😎 Browse the preview: https://deploy-preview-1032--kubernetes-sigs-cluster-api-openstack.netlify.app

[jichenjc]

/test pull-cluster-api-provider-openstack-e2e-test

[mdbooth]

/test pull-cluster-api-provider-openstack-e2e-test

Looks like this was required due to a flake in devstack 🤔 Lets keep an eye on how common this is. If this happens too often, this would be a more compelling reason to bring back preinstalled than the time saved.

[tobiasgiese]

Because of

Stop using --stream for ginkgo output

Should we also stop using -stream for the ginkgo conformance tests?

cluster-api-provider-openstack/Makefile

Line 145 in c12f58b

CONFORMANCE_GINKGO_ARGS ?= -stream

Because the target test-e2e will also trigger the target test-e2e-image-prerequisites

Edit: I just checked the output. I don't think that will give us any advantages 🙂 okay with it as is

[tobiasgiese]

/lgtm

[hidekazuna]

/approve

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hidekazuna, mdbooth

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [hidekazuna]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment