✨ getOrCreatePort: add support to configure QoS profile ID on ports

[EmilienM]

What this PR does / why we need it:

Adding support to configure Neutron ports with a specific QoS profile
ID:
https://docs.openstack.org/api-ref/network/v2/?expanded=show-port-details-detail#id54

This feature is already supported by Gophercloud:
https://github.com/gophercloud/gophercloud/blob/master/openstack/networking/v2/extensions/qos/policies/requests.go

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #1007

[netlify]

✔️ Deploy Preview for kubernetes-sigs-cluster-api-openstack ready!

🔨 Explore the source changes: 49f70c4

🔍 Inspect the deploy log: https://app.netlify.com/sites/kubernetes-sigs-cluster-api-openstack/deploys/615cbedb68868200070f2b28

😎 Browse the preview: https://deploy-preview-1008--kubernetes-sigs-cluster-api-openstack.netlify.app

[k8s-ci-robot]

Hi @EmilienM. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[EmilienM]

/ok-to-test

[k8s-ci-robot]

@EmilienM: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/ok-to-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[mdbooth]

/ok-to-test

[mdbooth]

/assign

[jichenjc]

/approve

[jichenjc]

/approve cancel

oops, the failure is valid .. need some update
pkg/cloud/services/networking/port.go:145:26: invalid operation: portOpts.QoSPolicyID != nil (mismatched types string and nil)

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: EmilienM
To complete the pull request process, please assign neolit123 after the PR has been reviewed.
You can assign the PR to them by writing /assign @neolit123 in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[mdbooth]

@EmilienM Can you think of a way we could reasonably test this? Perhaps creating a QoS policy in an E2E test and creating a port to use it?

[mdbooth]

@EmilienM You need to run make generate

[EmilienM]

@EmilienM Can you think of a way we could reasonably test this? Perhaps creating a QoS policy in an E2E test and creating a port to use it?

yes, this will imply the qos extension enabled in Neutron. I can look at that at some point, certainly.

[jichenjc]

@EmilienM Can you think of a way we could reasonably test this? Perhaps creating a QoS policy in an E2E test and creating a port to use it?

yes, this will imply the qos extension enabled in Neutron. I can look at that at some point, certainly.

we can customize the devstack , it should be not that hard , some changes
already done here
https://github.com/kubernetes-sigs/cluster-api-provider-openstack/pull/1009/files
you can refer to

[mdbooth]

@EmilienM Can you think of a way we could reasonably test this? Perhaps creating a QoS policy in an E2E test and creating a port to use it?

yes, this will imply the qos extension enabled in Neutron. I can look at that at some point, certainly.

we can customize the devstack , it should be not that hard , some changes
already done here
https://github.com/kubernetes-sigs/cluster-api-provider-openstack/pull/1009/files
you can refer to

Looks like QoS is already in there.

[EmilienM]

I'm looking at e2e testing today.

[EmilienM]

/test pull-cluster-api-provider-openstack-e2e-test

[EmilienM]

TODO: I need to finish the e2e test to confirm that we actually get the port with the right QoS Policy ID. Will do asap.

[mdbooth]

@EmilienM re the e2e test, could it live with the other custom ports test instead? I was hoping that test might grow into a mega test of everything.

[mdbooth]

That test failure 🤔

    Request forbidden: [POST http://10.0.2.15:9696/v2.0/qos/policies], error message: {"NeutronError": {"type": "PolicyNotAuthorized", "message": "rule:create_policy is disallowed by policy", "detail": ""}}

Is policy creation admin-only by any chance? That shouldn't be an insurmountable problem, but it might make it a bit different.

[EmilienM]

I'm missing the bits later in this test to confirm that the port has been created with a specific Policy ID.
@mdbooth I might use your help on this one

[iamemilio]

@EmilienM you should be able to unpack the the port into a struct that extends the port struct with the qos policy extension. I know openstack supports returning the qos policy for ports, and this is the gophercloud way to do it. It would look something like this:

type qosPort struct {
  ports.Port
  policies.QoSPolicyExt
}

opts := ports.ListOpts{ foo }
portList := []qosPort{}
err := ports.List(client, opts).ExtractInto(&portList)
if err != nil {
  ...
}

Expect (portList[0].QoSPolicyExt.QoSPolicyID).To(Equal(<uuid>))

[k8s-ci-robot]

@EmilienM: PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[hidekazuna]

@EmilienM v1beta1 API is merged(#1047). update to change v1beta1 API, please.

[k8s-triage-robot]

The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

• After 90d of inactivity, lifecycle/stale is applied
• After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
• After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

• Mark this issue or PR as fresh with /remove-lifecycle stale
• Mark this issue or PR as rotten with /lifecycle rotten
• Close this issue or PR with /close
• Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

[k8s-triage-robot]

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

• After 90d of inactivity, lifecycle/stale is applied
• After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
• After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

• Mark this issue or PR as fresh with /remove-lifecycle rotten
• Close this issue or PR with /close
• Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle rotten

[k8s-triage-robot]

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

• After 90d of inactivity, lifecycle/stale is applied
• After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
• After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

• Reopen this issue or PR with /reopen
• Mark this issue or PR as fresh with /remove-lifecycle rotten
• Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/close

[k8s-ci-robot]

@k8s-triage-robot: Closed this PR.

In response to this:

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

• After 90d of inactivity, lifecycle/stale is applied
• After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
• After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

• Reopen this issue or PR with /reopen
• Mark this issue or PR as fresh with /remove-lifecycle rotten
• Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.