Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add description and tag of created floating ip #868

Closed
jichenjc opened this issue May 17, 2021 · 4 comments
Closed

Add description and tag of created floating ip #868

jichenjc opened this issue May 17, 2021 · 4 comments
Assignees
Labels
kind/feature Categorizes issue or PR as related to a new feature.

Comments

@jichenjc
Copy link
Contributor

/kind feature

Describe the solution you'd like
[A clear and concise description of what you want to happen.]

Floating ip should honor the tag settings and add descriptions as well..

Anything else you would like to add:
[Miscellaneous information that will assist in solving the issue.]

@k8s-ci-robot k8s-ci-robot added the kind/feature Categorizes issue or PR as related to a new feature. label May 17, 2021
@tobiasgiese
Copy link
Member

I'll take a look at it and create a PR the next days.

/assign

@tobiasgiese
Copy link
Member

tobiasgiese commented Jul 5, 2021

Fixed with #925
/close

Edit: @jichenjc can you please assist here :)

@k8s-ci-robot
Copy link
Contributor

@tobiasgiese: You can't close an active issue/PR unless you authored it or you are a collaborator.

In response to this:

Fixed with #925
/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@jichenjc
Copy link
Contributor Author

jichenjc commented Jul 7, 2021

@tobiasgiese thanks for the reminder :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature Categorizes issue or PR as related to a new feature.
Projects
None yet
Development

No branches or pull requests

3 participants