Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove FloatingIP from OpenStackMachineSpec #1674

Closed
mdbooth opened this issue Sep 15, 2023 · 6 comments · Fixed by #1739 or #1824
Closed

Remove FloatingIP from OpenStackMachineSpec #1674

mdbooth opened this issue Sep 15, 2023 · 6 comments · Fixed by #1739 or #1824
Assignees
@EmilienM
Labels
kind/feature Categorizes issue or PR as related to a new feature.
Milestone
v1beta1

Comments

@mdbooth
Copy link
Contributor

mdbooth commented Sep 15, 2023

/kind feature

FloatingIP is not used by the machine controller, only the Bastion. We should move the floating IP configuration to the Bastion spec (OpenStackCluster.Spec.Bastion) instead.
@mdbooth mdbooth added this to the v1beta1 milestone Sep 15, 2023
@k8s-ci-robot k8s-ci-robot added the kind/feature Categorizes issue or PR as related to a new feature. label Sep 15, 2023
@mdbooth mdbooth mentioned this issue Sep 15, 2023
Closed
@mdbooth mdbooth mentioned this issue Oct 4, 2023
Closed
@mdbooth mdbooth mentioned this issue Oct 13, 2023
Closed
3 tasks
@EmilienM
Copy link
Contributor

EmilienM commented Nov 1, 2023

I agree with Matt, it's only used in the Bastion, see https://github.com/shiftstack/cluster-api-provider-openstack/blob/070714eaa24a25ec6774cbae1c6e140eb8babebe/controllers/openstackcluster_controller.go#L362-L363

@EmilienM EmilienM mentioned this issue Nov 1, 2023
Merged
4 tasks
@EmilienM
Copy link
Contributor

EmilienM commented Dec 7, 2023

/reopen

We are reverting. I'll re-add it to main once we have v1alpha8.

@k8s-ci-robot k8s-ci-robot reopened this Dec 7, 2023
@k8s-ci-robot
Copy link
Contributor

@EmilienM: Reopened this issue.

In response to this:

/reopen

We are reverting. I'll re-add it to main once we have v1alpha8.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@EmilienM
Copy link
Contributor

EmilienM commented Dec 7, 2023

/assign EmilienM

@mdbooth
Copy link
Contributor Author

mdbooth commented Jan 10, 2024

@EmilienM We put this back, right?

@EmilienM
Copy link
Contributor

yes, we reverted. I'll get back to it at some point.

@mdbooth mdbooth mentioned this issue Jan 12, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@EmilienM EmilienM

Labels
kind/feature Categorizes issue or PR as related to a new feature.
Projects
None yet
Milestone
v1beta1
3 participants
@mdbooth @EmilienM @k8s-ci-robot