Stop removing FIP-assoc when worker is removed

kubernetes-sigs · Oct 16, 2023 · 9d64ad3 · 9d64ad3
1 parent 24ad578
commit 9d64ad3
Showing 1 changed file with 0 additions and 8 deletions.
diff --git a/controllers/openstackmachine_controller.go b/controllers/openstackmachine_controller.go
@@ -273,14 +273,6 @@ func (r *OpenStackMachineReconciler) reconcileDelete(scope scope.Scope, cluster
 		}
 	}
 
-	// If this is a worker node and it has a floating IP attached, disassociate it.
-	if !util.IsControlPlaneMachine(machine) && openStackMachine.Spec.FloatingIP != "" {
-		if err = networkingService.DisassociateFloatingIP(machine, openStackMachine.Spec.FloatingIP); err != nil {
-			conditions.MarkFalse(openStackMachine, infrav1.APIServerIngressReadyCondition, infrav1.FloatingIPErrorReason, clusterv1.ConditionSeverityError, "Disassociating floating IP failed: %v", err)
-			return ctrl.Result{}, fmt.Errorf("disassociate floating IP: %w", err)
-		}
-	}
-
 	instanceSpec := machineToInstanceSpec(openStackCluster, machine, openStackMachine, "")
 
 	if err := computeService.DeleteInstance(openStackCluster, openStackMachine, instanceStatus, instanceSpec); err != nil {