This repository has been archived by the owner on Oct 28, 2024. It is now read-only.
Moving api -> apis and setting multigroup: true #26
+45
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
the
cncf-cla: yes
k8s-ci-robot
added
approved
christopherhein
commented
Dec 17, 2020
| _ = clusterv1.AddToScheme(scheme) | ||
| utilruntime.Must(clientgoscheme.AddToScheme(scheme)) | ||
| utilruntime.Must(clusterv1.AddToScheme(scheme)) | ||
| utilruntime.Must(controlplanev1alpha4.AddToScheme(scheme)) |
There was a problem hiding this comment.
utilruntime.Must() will fail if the types aren't loaded.
|
/assign @Fei-Guo @charleszheng44 |
Fei-Guo
approved these changes
Dec 17, 2020
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: christopherhein, Fei-Guo The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
needs-rebase
|
@christopherhein Please rebase to resolve the conflict. |
Signed-off-by: Chris Hein <[email protected]>
christopherhein
force-pushed
the
feature/move-to-multi-group
branch
from
e0444f0 to
655a0f2
Compare
k8s-ci-robot
removed
the
needs-rebase
|
Thanks @Fei-Guo all updated. Just needs. |
|
/lgtm |
k8s-ci-robot
added
the
lgtm
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Once we have
NestedClusterwe're going to need to have amultigroupcontrollers turned on to save a bunch of pain later this moved NCP intoapis/controlplanes. This also brings the Dockerfile from a standardkubebuilderproject.Signed-off-by: Chris Hein [email protected]