Added documentaion for usage of ClusterClass to create Power VS cluster #969
Conversation
k8s-ci-robot
added
the
area/provider/ibmcloud
✅ Deploy Preview for kubernetes-sigs-cluster-api-ibmcloud ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
k8s-ci-robot
added
the
cncf-cla: yes
k8s-ci-robot
added
the
size/M
k8s-ci-robot
added
the
lgtm
| ### Deploy Power VS cluster with IBM Power VS cloud provider | ||
|
|
||
| ``` | ||
| CLUSTER_CLASS_NAME="powervs-cc" \ |
There was a problem hiding this comment.
Rest all the variables are in the format of IBMPOWERVS_* so wondering if need to rename this one too?
There was a problem hiding this comment.
I will change this to IBMPOWERVS_CLUSTER_CLASS_NAME
| EXP_CLUSTER_RESOURCE_SET: "true" | ||
| CLUSTER_TOPOLOGY: "true" |
There was a problem hiding this comment.
where these 2 variables are referenced? I don't see them anywhere in the code?
There was a problem hiding this comment.
Any supporting document who is using these variables will be great.
There was a problem hiding this comment.
ClusterClass is a Experimental feature: https://cluster-api.sigs.k8s.io/tasks/experimental-features/cluster-class/index.html.
Enabling the feature gate: https://github.com/kubernetes-sigs/cluster-api/blob/main/docs/book/src/user/quick-start.md#enabling-feature-gates
There was a problem hiding this comment.
do you mind adding same information into the doc?
There was a problem hiding this comment.
Yes sure, I can do that
| kustomize_substitutions: | ||
| IBMCLOUD_API_KEY: "XXXXXXXXXXXXXXXXXX" | ||
| POWERVS_PROVIDER_ID_FORMAT: "v2" | ||
| EXP_CLUSTER_RESOURCE_SET: "true" |
There was a problem hiding this comment.
do we need this EXP_CLUSTER_RESOURCE_SET for this section?
There was a problem hiding this comment.
Since we are using external cloud provider for cluster which intern needs cluster resource set which also behind this feature gate.
There was a problem hiding this comment.
Lets add that information into the doc
Karthik-K-N
force-pushed
the
clusterclass-docs
branch
from
78a4aba to
0ee8c41
Compare
k8s-ci-robot
removed
the
lgtm
Karthik-K-N
force-pushed
the
clusterclass-docs
branch
from
0ee8c41 to
83af086
Compare
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Karthik-K-N, mkumatag, Prajyot-Parab The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
What this PR does / why we need it:
ClusterClass support for Power VS was added with the PR: , This PR adds the documentation on how to create cluster using ClusterClass
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #
Special notes for your reviewer:
/area provider/ibmcloud
Release note: