Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump github.com/onsi/gomega from 1.22.1 to 1.24.0 #944

Closed

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Nov 2, 2022

Bumps github.com/onsi/gomega from 1.22.1 to 1.24.0.

Release notes

Sourced from github.com/onsi/gomega's releases.

v1.24.0

1.24.0

Features

Introducting gcustom - a convenient mechanism for building custom matchers.

This is an RC release for gcustom. The external API may be tweaked in response to feedback however it is expected to remain mostly stable.

Maintenance

  • Update BeComparableTo documentation [756eaa0]

v1.23.0

1.23.0

Features

  • Custom formatting on a per-type basis can be provided using format.RegisterCustomFormatter() -- see the docs here

  • Substantial improvement have been made to StopTrying():

    • Users can now use StopTrying().Wrap(err) to wrap errors and StopTrying().Attach(description, object) to attach arbitrary objects to the StopTrying() error
    • StopTrying() is now always interpreted as a failure. If you are an early adopter of StopTrying() you may need to change your code as the prior version would match against the returned value even if StopTrying() was returned. Going forward the StopTrying() api should remain stable.
    • StopTrying() and StopTrying().Now() can both be used in matchers - not just polled functions.
  • TryAgainAfter(duration) is used like StopTrying() but instructs Eventually and Consistently that the poll should be tried again after the specified duration. This allows you to dynamically adjust the polling duration.

  • ctx can now be passed-in as the first argument to Eventually and Consistently.

Maintenance

  • Bump github.com/onsi/ginkgo/v2 from 2.3.0 to 2.3.1 (#597) [afed901]
  • Bump nokogiri from 1.13.8 to 1.13.9 in /docs (#599) [7c691b3]
  • Bump github.com/google/go-cmp from 0.5.8 to 0.5.9 (#587) [ff22665]
Changelog

Sourced from github.com/onsi/gomega's changelog.

1.24.0

Features

Introducting gcustom - a convenient mechanism for building custom matchers.

This is an RC release for gcustom. The external API may be tweaked in response to feedback however it is expected to remain mostly stable.

Maintenance

  • Update BeComparableTo documentation [756eaa0]

1.23.0

Features

  • Custom formatting on a per-type basis can be provided using format.RegisterCustomFormatter() -- see the docs here

  • Substantial improvement have been made to StopTrying():

    • Users can now use StopTrying().Wrap(err) to wrap errors and StopTrying().Attach(description, object) to attach arbitrary objects to the StopTrying() error
    • StopTrying() is now always interpreted as a failure. If you are an early adopter of StopTrying() you may need to change your code as the prior version would match against the returned value even if StopTrying() was returned. Going forward the StopTrying() api should remain stable.
    • StopTrying() and StopTrying().Now() can both be used in matchers - not just polled functions.
  • TryAgainAfter(duration) is used like StopTrying() but instructs Eventually and Consistently that the poll should be tried again after the specified duration. This allows you to dynamically adjust the polling duration.

  • ctx can now be passed-in as the first argument to Eventually and Consistently.

Maintenance

  • Bump github.com/onsi/ginkgo/v2 from 2.3.0 to 2.3.1 (#597) [afed901]
  • Bump nokogiri from 1.13.8 to 1.13.9 in /docs (#599) [7c691b3]
  • Bump github.com/google/go-cmp from 0.5.8 to 0.5.9 (#587) [ff22665]
Commits
  • ed1156b v1.24.0
  • 756eaa0 Update BeComparableTo documentation
  • 6015576 finish documenting gcustom
  • 0cfc53b godoc for gcustom
  • 6a2e51e First pass at gcustom: a convenience package for making custom matchers. Doc...
  • bf817a4 v1.23.0
  • 7b8b801 fix broken call to Eventually
  • ba35cc6 Allow ctx to be passed in as a leading parameter for Eventually and Consistently
  • 818b78c AsyncAssertions emit the format.Object representation of the error when it i...
  • d63d67e Rename AsyncSignalError to PollingSignalError
  • Additional commits viewable in compare view

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Bumps [github.com/onsi/gomega](https://github.com/onsi/gomega) from 1.22.1 to 1.24.0.
- [Release notes](https://github.com/onsi/gomega/releases)
- [Changelog](https://github.com/onsi/gomega/blob/master/CHANGELOG.md)
- [Commits](onsi/gomega@v1.22.1...v1.24.0)

---
updated-dependencies:
- dependency-name: github.com/onsi/gomega
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
@dependabot dependabot bot added dependencies Pull requests that update a dependency file go Pull requests that update Go code labels Nov 2, 2022
@netlify
Copy link

netlify bot commented Nov 2, 2022

Deploy Preview for kubernetes-sigs-cluster-api-ibmcloud ready!

Name Link
🔨 Latest commit 2a10808
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-sigs-cluster-api-ibmcloud/deploys/6362efd2cb98c500084f3bdf
😎 Deploy Preview https://deploy-preview-944--kubernetes-sigs-cluster-api-ibmcloud.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Nov 2, 2022
@k8s-ci-robot
Copy link
Contributor

Hi @dependabot[bot]. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: dependabot[bot]
Once this PR has been reviewed and has the lgtm label, please assign mkumatag for approval by writing /assign @mkumatag in a comment. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Nov 2, 2022
@mkumatag mkumatag removed the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Nov 3, 2022
@mkumatag
Copy link
Member

mkumatag commented Nov 3, 2022

/ok-to-test

@k8s-ci-robot k8s-ci-robot added the ok-to-test Indicates a non-member PR verified by an org member that is safe to test. label Nov 3, 2022
@k8s-ci-robot
Copy link
Contributor

@dependabot[bot]: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-cluster-api-provider-ibmcloud-test 2a10808 link true /test pull-cluster-api-provider-ibmcloud-test
pull-cluster-api-provider-ibmcloud-smoke-test 2a10808 link true /test pull-cluster-api-provider-ibmcloud-smoke-test

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@mkumatag
Copy link
Member

mkumatag commented Nov 3, 2022

will be fixed via - #945

@mkumatag mkumatag closed this Nov 3, 2022
@dependabot @github
Copy link
Contributor Author

dependabot bot commented on behalf of github Nov 3, 2022

OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor version, let me know by commenting @dependabot ignore this major version or @dependabot ignore this minor version. You can also ignore all major, minor, or patch releases for a dependency by adding an ignore condition with the desired update_types to your config file.

If you change your mind, just re-open this PR and I'll resolve any conflicts on it.

@dependabot dependabot bot deleted the dependabot/go_modules/github.com/onsi/gomega-1.24.0 branch November 3, 2022 07:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. dependencies Pull requests that update a dependency file go Pull requests that update Go code ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants