-
Notifications
You must be signed in to change notification settings - Fork 84
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add externally managed annotations to IBMPowerVSCluster resource #899
Add externally managed annotations to IBMPowerVSCluster resource #899
Conversation
✅ Deploy Preview for kubernetes-sigs-cluster-api-ibmcloud ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Karthik-K-N, mkumatag, Prajyot-Parab The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/hold |
@Prajyot-Parab @Karthik-K-N @dharaneeshvrd can we make sure Especially with hypershift project. |
I think it should not affect any other things as we adding externally managed annotations only to IBMPowerVSCluster resource and within that recoincilation we are not doing anything other than setting ready status to true. |
I'm have concern about the delete flow because we are deleting them when delete cluster triggered. |
@mkumatag As you expected, in hypershift delete flow ibmpowervsimage did nt get deleted, due to that whole deletion got stuck(hosted control plane namespace and due to that hosted cluster). |
/hold |
@Karthik-K-N #938 is merged, hence can this be merged as well? |
Yes. |
/unhold |
What this PR does / why we need it:
This PR adds the filter to IBMPowerVSCluster reosurce to avoid reconciliation if the resource has the externally managed annotation(cluster.x-k8s.io/managed-by) set.
Enhancement: https://github.com/kubernetes-sigs/cluster-api/blob/10d89ceca938e4d3d94a1d1c2b60515bcdf39829/docs/proposals/20210203-externally-managed-cluster-infrastructure.md
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):Fixes #
Special notes for your reviewer:
/area provider/ibmcloud
Release note: