Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release-0.3] Remove unwanted logs #853

Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Remove unwanted logs
mkumatag authored and k8s-infra-cherrypick-robot committed Sep 12, 2022
commit ad5dd7b5d8f2611d87d268d1bc0a68206851627c
4 changes: 1 addition & 3 deletions cloud/scope/machine.go
Original file line number Diff line number Diff line change
@@ -18,7 +18,6 @@ package scope

import (
"context"
"fmt"

"github.com/IBM/go-sdk-core/v5/core"
"github.com/IBM/vpc-go-sdk/vpcv1"
@@ -154,13 +153,12 @@ func (m *MachineScope) CreateMachine() (*vpcv1.Instance, error) {
}

options.SetInstancePrototype(instancePrototype)
instance, response, err := m.IBMVPCClient.CreateInstance(options)
instance, _, err := m.IBMVPCClient.CreateInstance(options)
if err != nil {
record.Warnf(m.IBMVPCMachine, "FailedCreateInstance", "Failed instance creation - %v", err)
} else {
record.Eventf(m.IBMVPCMachine, "SuccessfulCreateInstance", "Created Instance %q", *instance.Name)
}
fmt.Printf("%v\n", response)
return instance, err
}

1 change: 0 additions & 1 deletion controllers/ibmpowervsmachine_controller.go
Original file line number Diff line number Diff line change
@@ -256,7 +256,6 @@ func (r *IBMPowerVSMachineReconciler) reconcileNormal(machineScope *scope.PowerV
machineScope.Info("PowerVS instance state is undefined", "state", *instance.Status, "instance-id", machineScope.GetInstanceID())
conditions.MarkUnknown(machineScope.IBMPowerVSMachine, infrav1beta1.InstanceReadyCondition, "", "")
}
machineScope.Info(*ins.PvmInstanceID)
}

// Requeue after 2 minute if machine is not ready to update status of the machine properly.
1 change: 0 additions & 1 deletion controllers/ibmvpcmachine_controller.go
Original file line number Diff line number Diff line change
@@ -196,7 +196,6 @@ func (r *IBMVPCMachineReconciler) reconcileNormal(machineScope *scope.MachineSco
}
}
machineScope.IBMVPCMachine.Status.Ready = true
machineScope.Info(*instance.ID)
}

return ctrl.Result{}, nil