Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add unit tests for VPC LB integration #851

Merged
merged 1 commit into from
Sep 23, 2022
Merged

Add unit tests for VPC LB integration #851

merged 1 commit into from
Sep 23, 2022

Conversation

Prajyot-Parab
Copy link
Contributor

@Prajyot-Parab Prajyot-Parab commented Sep 9, 2022 •
edited
Loading

Signed-off-by: Prajyot-Parab [email protected]

What this PR does / why we need it:

  • Add unit tests for VPC LB integration
  • Improved refactoring and optimisation of overall UTs

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #834

Special notes for your reviewer:

/area provider/ibmcloud

  1. Please confirm that if this PR changes any image versions, then that's the sole change this PR makes.

Release note:

Add unit tests for VPC LB integration

@k8s-ci-robot k8s-ci-robot added area/provider/ibmcloud Issues or PRs related to ibmcloud provider cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Sep 9, 2022
@k8s-ci-robot k8s-ci-robot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Sep 9, 2022
@netlify
Copy link

netlify bot commented Sep 9, 2022 •
edited
Loading

✅ Deploy Preview for kubernetes-sigs-cluster-api-ibmcloud ready!

Name Link
🔨 Latest commit bd92a69
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-sigs-cluster-api-ibmcloud/deploys/6328495458276900092892a4
😎 Deploy Preview https://deploy-preview-851--kubernetes-sigs-cluster-api-ibmcloud.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@Prajyot-Parab
Copy link
Contributor Author

/cc @mkumatag @Amulyam24

Amulyam24
Amulyam24 approved these changes Sep 12, 2022
View reviewed changes
Copy link
Contributor

@Amulyam24 Amulyam24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 12, 2022
@Prajyot-Parab
Copy link
Contributor Author

/retest

@Prajyot-Parab
Copy link
Contributor Author

/retest-all

@Prajyot-Parab
Copy link
Contributor Author

/test all

@mkumatag
Copy link
Member

@Prajyot-Parab: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-cluster-api-provider-ibmcloud-coverage 4a874a4 link true /test pull-cluster-api-provider-ibmcloud-coverage
pull-cluster-api-provider-ibmcloud-test 4a874a4 link true /test pull-cluster-api-provider-ibmcloud-test
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

@Prajyot-Parab this could be because of the code added recently for the user supplied ports, to fix this you need to initialise the cluster struct in the tests like

cluster-api-provider-ibmcloud/controllers/ibmvpccluster_controller_test.go

Line 153 in b278813

Cluster: &capiv1beta1.Cluster{},

@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 12, 2022
@Prajyot-Parab Prajyot-Parab requested review from Amulyam24 and removed request for wentao-zh, mkumatag and jichenjc September 12, 2022 11:07
@Prajyot-Parab
Copy link
Contributor Author

/cc @mkumatag

@Prajyot-Parab
Copy link
Contributor Author

@Prajyot-Parab: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:
Test name Commit Details Required Rerun command
pull-cluster-api-provider-ibmcloud-coverage 4a874a4 link true /test pull-cluster-api-provider-ibmcloud-coverage
pull-cluster-api-provider-ibmcloud-test 4a874a4 link true /test pull-cluster-api-provider-ibmcloud-test
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

@Prajyot-Parab this could be because of the code added recently for the user supplied ports, to fix this you need to initialise the cluster struct in the tests like

cluster-api-provider-ibmcloud/controllers/ibmvpccluster_controller_test.go

Line 153 in b278813

Cluster: &capiv1beta1.Cluster{},

Yes, fixed it.

Amulyam24
Amulyam24 approved these changes Sep 12, 2022
View reviewed changes
Copy link
Contributor

@Amulyam24 Amulyam24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 12, 2022
mkumatag
mkumatag requested changes Sep 15, 2022
View reviewed changes
cloud/scope/cluster_test.go Outdated Show resolved Hide resolved
cloud/scope/cluster_test.go Outdated Show resolved Hide resolved
cloud/scope/cluster_test.go Outdated Show resolved Hide resolved
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 15, 2022
@Prajyot-Parab
Copy link
Contributor Author

/cc @Amulyam24 @mkumatag

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Sep 16, 2022
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Sep 16, 2022
@Prajyot-Parab Prajyot-Parab changed the title Add unit tests for VPC LB integration WIP - Add unit tests for VPC LB integration Sep 16, 2022
@k8s-ci-robot k8s-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 16, 2022
@Prajyot-Parab Prajyot-Parab force-pushed the update branch 2 times, most recently from 482c94b to b4a084e Compare September 19, 2022 10:43
@Prajyot-Parab Prajyot-Parab changed the title WIP - Add unit tests for VPC LB integration Add unit tests for VPC LB integration Sep 19, 2022
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 19, 2022
@Prajyot-Parab
Copy link
Contributor Author

/cc @Amulyam24 @mkumatag PTAL

@k8s-ci-robot
Copy link
Contributor

@Prajyot-Parab: GitHub didn't allow me to request PR reviews from the following users: PTAL.

Note that only kubernetes-sigs members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

/cc @Amulyam24 @mkumatag PTAL

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

mkumatag
mkumatag approved these changes Sep 23, 2022
View reviewed changes
Copy link
Member

@mkumatag mkumatag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 23, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Amulyam24, mkumatag, Prajyot-Parab

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 23, 2022
@k8s-ci-robot k8s-ci-robot merged commit 3cf2b75 into kubernetes-sigs:main Sep 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mkumatag mkumatag mkumatag approved these changes

@Amulyam24 Amulyam24 Awaiting requested review from Amulyam24

Assignees

@mkumatag mkumatag

@Amulyam24 Amulyam24

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/provider/ibmcloud Issues or PRs related to ibmcloud provider cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Unit tests for the LB VPC integration
4 participants
@Prajyot-Parab @mkumatag @k8s-ci-robot @Amulyam24