-
Notifications
You must be signed in to change notification settings - Fork 84
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fetch internal IP from dhcp server #748
Fetch internal IP from dhcp server #748
Conversation
✅ Deploy Preview for kubernetes-sigs-cluster-api-ibmcloud ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
8e38973
to
8451937
Compare
8451937
to
bd28908
Compare
/cc @mkumatag |
yet to test the new change on a cluster but good for review and approach choosen |
Tested on a hypershift cluster and works as expected, Able to see InternalIP set for machine
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Karthik-K-N, mkumatag The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/cherry-pick release-0.2 |
@mkumatag: #748 failed to apply on top of branch "release-0.2":
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@Karthik-K-N do you mind back porting this PR to release-0.2 branch as well? |
What this PR does / why we need it:
This PR contains the changes to fetch the IP for a VM from DHCP+ server and store it in cache for maximum of 20 minutes to avoid frequent power cloud api calls.
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):Fixes ##723
Special notes for your reviewer:
/area provider/ibmcloud
Release note: