Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update docker to 1.18 version #724

Merged
merged 1 commit into from
Jun 27, 2022
Merged

Update docker to 1.18 version #724

merged 1 commit into from
Jun 27, 2022

Conversation

mkumatag
Copy link
Member

What this PR does / why we need it:

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #666

Special notes for your reviewer:

/area provider/ibmcloud

  1. Please confirm that if this PR changes any image versions, then that's the sole change this PR makes.

Release note:

@k8s-ci-robot k8s-ci-robot added the area/provider/ibmcloud Issues or PRs related to ibmcloud provider label Jun 27, 2022
@netlify
Copy link

netlify bot commented Jun 27, 2022 •
edited
Loading

✅ Deploy Preview for kubernetes-sigs-cluster-api-ibmcloud ready!

Name Link
🔨 Latest commit 407fb87
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-sigs-cluster-api-ibmcloud/deploys/62b959a82d9fed00082e3f22
😎 Deploy Preview https://deploy-preview-724--kubernetes-sigs-cluster-api-ibmcloud.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jun 27, 2022
@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jun 27, 2022
@mkumatag
Copy link
Member Author

/cc @Amulyam24 @Prajyot-Parab

@Amulyam24
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 27, 2022
@mkumatag
Copy link
Member Author

/hold

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 27, 2022
@mkumatag mkumatag mentioned this pull request Jun 27, 2022
Closed
4 tasks
@mkumatag
Copy link
Member Author

Waiting for kubernetes/test-infra#26678 to merge

Prajyot-Parab
Prajyot-Parab approved these changes Jun 27, 2022
View reviewed changes
Copy link
Contributor

@Prajyot-Parab Prajyot-Parab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mkumatag, Prajyot-Parab

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@mkumatag
Copy link
Member Author

/test ?

@k8s-ci-robot
Copy link
Contributor

@mkumatag: The following commands are available to trigger required jobs:

  • /test pull-cluster-api-provider-ibmcloud-build
  • /test pull-cluster-api-provider-ibmcloud-coverage
  • /test pull-cluster-api-provider-ibmcloud-make
  • /test pull-cluster-api-provider-ibmcloud-smoke-test
  • /test pull-cluster-api-provider-ibmcloud-test
  • /test pull-cluster-api-provider-ibmcloud-verify

Use /test all to run all jobs.

In response to this:

/test ?

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@mkumatag
Copy link
Member Author

/test all

@mkumatag mkumatag closed this Jun 27, 2022
@mkumatag mkumatag reopened this Jun 27, 2022
@mkumatag
Copy link
Member Author

/unhold

Now all the jobs are run with 1.24 version

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 27, 2022
@k8s-ci-robot k8s-ci-robot merged commit 8a12b07 into kubernetes-sigs:main Jun 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Prajyot-Parab Prajyot-Parab Prajyot-Parab approved these changes

@gyliu513 gyliu513 Awaiting requested review from gyliu513

@wentao-zh wentao-zh Awaiting requested review from wentao-zh

@Amulyam24 Amulyam24 Awaiting requested review from Amulyam24

Assignees

@Amulyam24 Amulyam24

@Prajyot-Parab Prajyot-Parab

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/provider/ibmcloud Issues or PRs related to ibmcloud provider cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Adopt k8s 1.24
4 participants
@mkumatag @Amulyam24 @k8s-ci-robot @Prajyot-Parab