Handle the ERRORED state properly #642
Conversation
k8s-ci-robot
added
area/provider/ibmcloud
✅ Deploy Preview for kubernetes-sigs-cluster-api-ibmcloud ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
k8s-ci-robot
added
the
approved
|
/cc @Prajyot-Parab |
k8s-ci-robot
added
the
size/S
| } | ||
| machineScope.SetNotReady() | ||
| conditions.MarkFalse(machineScope.IBMPowerVSMachine, infrav1beta1.InstanceReadyCondition, infrav1beta1.InstanceErroredReason, capiv1beta1.ConditionSeverityError, msg) | ||
| capibmrecord.Warnf(machineScope.IBMPowerVSMachine, "FailedBuildInstance", "Failed to build the instance - %s", msg) |
There was a problem hiding this comment.
@mkumatag Overall LGTM, just a minor query - won't this event be recorded with every reconcile run {multiple times} (incase of an errored instance)?
There was a problem hiding this comment.
For failure it is expected to record multiple times(how many times really happened)
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mkumatag, Prajyot-Parab The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What this PR does / why we need it:
This PR handle the ERRORED state of the virtual server properly.
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #
Special notes for your reviewer:
/area provider/ibmcloud
Release note: