Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Validate machine spec values #626

Merged
merged 1 commit into from
Apr 29, 2022
Merged

Validate machine spec values #626

merged 1 commit into from
Apr 29, 2022

Conversation

Prajyot-Parab
Copy link
Contributor

Signed-off-by: Prajyot-Parab [email protected]

What this PR does / why we need it:

  • Validate machine spec memory/processors values.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #596

Special notes for your reviewer:

/area provider/ibmcloud

  1. Please confirm that if this PR changes any image versions, then that's the sole change this PR makes.

Release note:

Validate machine spec values.

@k8s-ci-robot k8s-ci-robot added area/provider/ibmcloud Issues or PRs related to ibmcloud provider cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Apr 8, 2022
@netlify
Copy link

netlify bot commented Apr 8, 2022 •
edited
Loading

✅ Deploy Preview for kubernetes-sigs-cluster-api-ibmcloud ready!

Name Link
🔨 Latest commit 1f63c70
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-sigs-cluster-api-ibmcloud/deploys/626b8e384008fc0008d2d5d7
😎 Deploy Preview https://deploy-preview-626--kubernetes-sigs-cluster-api-ibmcloud.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Apr 8, 2022
@Prajyot-Parab
Copy link
Contributor Author

/cc @mkumatag

@k8s-ci-robot k8s-ci-robot requested a review from mkumatag April 8, 2022 08:37
mkumatag
mkumatag requested changes Apr 9, 2022
View reviewed changes
api/v1beta1/common.go Outdated Show resolved Hide resolved
api/v1beta1/ibmpowervsmachine_webhook.go Outdated Show resolved Hide resolved
@Prajyot-Parab Prajyot-Parab requested a review from mkumatag April 11, 2022 08:10
mkumatag
mkumatag requested changes Apr 11, 2022
View reviewed changes
api/v1beta1/common.go Outdated Show resolved Hide resolved
@Prajyot-Parab Prajyot-Parab requested a review from mkumatag April 22, 2022 13:41
@Prajyot-Parab
Copy link
Contributor Author

/cc @mkumatag

mkumatag
mkumatag requested changes Apr 26, 2022
View reviewed changes
api/v1beta1/ibmpowervsmachine_types.go Outdated Show resolved Hide resolved
@Prajyot-Parab Prajyot-Parab requested a review from mkumatag April 28, 2022 11:28
mkumatag
mkumatag requested changes Apr 28, 2022
View reviewed changes
api/v1beta1/common.go Outdated Show resolved Hide resolved
api/v1beta1/common.go Show resolved Hide resolved
api/v1beta1/common.go Show resolved Hide resolved
@Prajyot-Parab
validate machine spec values
1f63c70 
Signed-off-by: Prajyot-Parab <[email protected]>
@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Apr 29, 2022
@Prajyot-Parab Prajyot-Parab requested a review from mkumatag April 29, 2022 07:07
mkumatag
mkumatag approved these changes Apr 29, 2022
View reviewed changes
Copy link
Member

@mkumatag mkumatag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 29, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mkumatag, Prajyot-Parab

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 29, 2022
@k8s-ci-robot k8s-ci-robot merged commit 6ffeb55 into kubernetes-sigs:main Apr 29, 2022
@Prajyot-Parab Prajyot-Parab deleted the lint branch June 10, 2022 12:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mkumatag mkumatag mkumatag approved these changes

@relyt0925 relyt0925 Awaiting requested review from relyt0925

@wentao-zh wentao-zh Awaiting requested review from wentao-zh

Assignees

@mkumatag mkumatag

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/provider/ibmcloud Issues or PRs related to ibmcloud provider cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

IBMPowerVSMachine failed to create with message failed to convert memory() to float64
3 participants
@Prajyot-Parab @k8s-ci-robot @mkumatag